provide OTA defaults (#77)

(cherry picked from commit 438b258)

Author: rjwats

lib/framework/OTASettingsService.cpp

@@ -25,14 +25,9 @@ void OTASettingsService::onConfigUpdated() {
 }
 
 void OTASettingsService::readFromJsonObject(JsonObject& root) {
-  _enabled = root["enabled"];
-  _port = root["port"];
+  _enabled = root["enabled"] | DEFAULT_OTA_ENABLED;
+  _port = root["port"] | DEFAULT_OTA_PORT;
   _password = root["password"] | DEFAULT_OTA_PASSWORD;
-
-  // provide defaults
-  if (_port < 0) {
-    _port = DEFAULT_OTA_PORT;
-  }
 }
 
 void OTASettingsService::writeToJsonObject(JsonObject& root) {

lib/framework/OTASettingsService.h

@@ -15,6 +15,7 @@
 // Emergency defaults
 #define DEFAULT_OTA_PORT 8266
 #define DEFAULT_OTA_PASSWORD "esp-react"
+#define DEFAULT_OTA_ENABLED true
 
 #define OTA_SETTINGS_FILE "/config/otaSettings.json"
 #define OTA_SETTINGS_SERVICE_PATH "/rest/otaSettings"