Skip to content

Commit 9880e44

Browse files
committed
Drop support for PHP < 7.3
Ref #119
1 parent 2a389a9 commit 9880e44

File tree

5 files changed

+10
-11
lines changed

5 files changed

+10
-11
lines changed

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77
runs-on: ubuntu-latest
88
strategy:
99
matrix:
10-
php: ['5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
10+
php: ['7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
1111
name: PHP ${{ matrix.php }}
1212
steps:
1313
- name: Checkout

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"homepage": "https://github.com/rlanvin/php-rrule",
77
"license": "MIT",
88
"require": {
9-
"php": ">=5.6.0"
9+
"php": ">=7.3"
1010
},
1111
"suggest": {
1212
"ext-intl": "Intl extension is needed for humanReadable()"
@@ -22,7 +22,7 @@
2222
}
2323
},
2424
"require-dev": {
25-
"phpunit/phpunit": "^5.7|^6.5|^8.0",
25+
"phpunit/phpunit": "^8.0",
2626
"phpmd/phpmd" : "@stable"
2727
}
2828
}

phpunit.xml.dist

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
convertWarningsToExceptions="true"
99
processIsolation="false"
1010
stopOnFailure="false"
11-
syntaxCheck="false"
1211
bootstrap="./tests/bootstrap.php"
1312
>
1413
<testsuites>

tests/RRuleTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2281,7 +2281,7 @@ public function testQuirkyRfcStringsParser($str,$occurrences)
22812281
$rule = @ new RRule($str);
22822282

22832283
if ($occurrences) {
2284-
$this->assertEquals($occurrences, $rule->getOccurrences(), '', 1);
2284+
$this->assertEquals($occurrences, $rule->getOccurrences());
22852285
}
22862286
}
22872287

@@ -2827,10 +2827,10 @@ public function testGetRule()
28272827
'DTSTART' => '2016-01-01'
28282828
);
28292829
$rrule = new RRule($array);
2830-
$this->assertInternalType('array', $rrule->getRule());
2830+
$this->assertIsArray($rrule->getRule());
28312831
$rule = $rrule->getRule();
28322832
$this->assertEquals('YEARLY', $rule['FREQ']);
2833-
$this->assertInternalType('string', $rule['DTSTART']);
2833+
$this->assertIsString($rule['DTSTART']);
28342834

28352835
$rrule = new RRule("DTSTART;TZID=America/New_York:19970901T090000\nRRULE:FREQ=HOURLY;UNTIL=19971224T000000Z;WKST=SU;BYDAY=MO,WE,FR;BYMONTH=1;BYHOUR=1");
28362836
$rule = $rrule->getRule();

tests/RSetTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -591,13 +591,13 @@ public function testGetter()
591591
'DTSTART' => date_create('1997-09-02 09:00')
592592
));
593593

594-
$this->assertInternalType('array', $rset->getRRules());
594+
$this->assertIsArray($rset->getRRules());
595595
$this->assertCount(2, $rset->getRRules());
596-
$this->assertInternalType('array', $rset->getExRules());
596+
$this->assertIsArray($rset->getExRules());
597597
$this->assertCount(1, $rset->getExRules());
598-
$this->assertInternalType('array', $rset->getDates());
598+
$this->assertIsArray($rset->getDates());
599599
$this->assertCount(3, $rset->getDates());
600-
$this->assertInternalType('array', $rset->getExDates());
600+
$this->assertIsArray($rset->getExDates());
601601
$this->assertCount(0, $rset->getExDates());
602602
}
603603

0 commit comments

Comments
 (0)