Fix RSet not de-duplicating when using array access

Ref #165

Author: rlanvin

CHANGELOG.md

@@ -10,6 +10,7 @@
 ### Fixed
 
 - Added a workaround for a Carbon 3 bug that makes occursAt fail in some cases [#164](https://github.com/rlanvin/php-rrule/issues/164)
+- Fix RSet not de-duplicating when using array access [#165](https://github.com/rlanvin/php-rrule/issues/165)
 
 ## [2.6.0] - 2025-04-25
 

src/RSet.php

@@ -600,14 +600,15 @@ public function count()
 	#[\ReturnTypeWillChange]
 	public function getIterator()
 	{
-		$previous_occurrence = null;
 		$total = 0;
 
+		$occurrence = null;
 		foreach ($this->cache as $occurrence) {
 			yield clone $occurrence; // since DateTime is not immutable, avoid any problem
 
 			$total += 1;
 		}
+		$previous_occurrence = $occurrence;
 
 		if ($this->rlist_heap === null) {
 			// rrules + rdate

tests/RSetTest.php

@@ -87,6 +87,36 @@ public function testCombineRRuleAndDate()
 		$this->assertFalse($rset->occursAt('1997-09-03 09:00'));
 	}
 
+	/**
+	 * @see https://github.com/rlanvin/php-rrule/issues/165
+	 */
+	public function testCombineRRuleAndRDateWithDuplicatesArrayAccess()
+	{
+		$rset = new RSet();
+		$rset->addRRule(array(
+			'FREQ' => 'WEEKLY',
+			'BYDAY' => 'TU',
+			'DTSTART' => date_create('2025-06-03 09:00')
+		));
+		$rset->addDate('2025-06-03 09:00');
+		$rset->addDate('2025-06-10 09:00');
+		$rset->addDate('2025-06-11 09:00');
+
+		$occurences = [];
+		for ($i = 0; $i < 5; $i++) {
+			$occurences[] = $rset[$i];
+		}
+		$expected = [
+			date_create('2025-06-03 09:00'),
+			date_create('2025-06-10 09:00'),
+			date_create('2025-06-11 09:00'),
+			date_create('2025-06-17 09:00'),
+			date_create('2025-06-24 09:00')
+		];
+
+		$this->assertEquals($expected, $occurences);
+	}
+
 	public function testRemoveDateFromRSet()
 	{
 		$rset = new RSet();