Incorrect returned value

[astralo]

Lang.js/src/lang.js

Line 288 in 31474a8

if (message[subKey] !== undefined) {

if we have two lines as

    'book.btn.finish'               => 'Finish Booking',
    'book.btn'                        => 'Book Now',

and request Lang.get('book.btn.finish') then _getMessage returned 'Book Now'

[astralo]

 if (message[subKey] && entries.length === 0) {

instead

 if (message[subKey] !== undefined) {

solves the problem

[rmariuzzo]

Hey @astralo! We need to create a test case we your proposed changes. Thanks for letting me know.

[RomeroMsk]

I ran into the similar issue.

Imagine the situation when you validate an input array with the nested fields in Laravel:

$request->validate([
    ...
    'location' => 'array',
    'location.city_id' => 'required',
    ...
]);

To localize the validation messages for both location and location.city_id attributes we need to add two translation strings:

// resources/lang/en/validation.php

return [
    ...
    'attributes' => [
        ...
        'location' => 'Location',
        'location.city_id' => 'City',
        ...
    ],
];

And in this case, if we want to use the validation.php file as a source for Lang.js, we will get the Location translation result for the lang.get('validation.attributes.location.city_id') call (instead of City).

[RomeroMsk]

Any news on this?

[rmariuzzo]

@RomeroMsk I will try to revisit it on this weekend.

[RomeroMsk]

Bump.

[alfonsobries]

FYI I created a PR that solve this issue: #74 @astralo

In the meanwhile you can use that fork in package.json:

"lang.js": "https://github.com/alfonsobries/Lang.js#feature/proritize-dot-notations",