[spiders] Remove 'spider' argument to ExecutionEngine.crawl (#286)

Author: mic1on

src/scrapy_redis/spiders.py

@@ -1,6 +1,6 @@
 import json
 from collections.abc import Iterable
-from scrapy import signals, FormRequest
+from scrapy import signals, FormRequest, version_info as scrapy_version
 from scrapy.exceptions import DontCloseSpider
 from scrapy.spiders import Spider, CrawlSpider
 from scrapy_redis.utils import TextColor
@@ -190,7 +190,11 @@ def schedule_next_requests(self):
         """Schedules a request if available"""
         # TODO: While there is capacity, schedule a batch of redis requests.
         for req in self.next_requests():
-            self.crawler.engine.crawl(req, spider=self)
+            # see https://github.com/scrapy/scrapy/issues/5994
+            if scrapy_version >= (2, 6):
+                self.crawler.engine.crawl(req)
+            else:
+                self.crawler.engine.crawl(req, spider=self)
 
     def spider_idle(self):
         """

tests/test_spiders.py

@@ -165,9 +165,9 @@ def test_consume_urls_from_redis(start_urls_as_zset, start_urls_as_set, spider_c
 
         if start_urls_as_zset or start_urls_as_set:
             crawler.engine.crawl.assert_has_calls([
-                mock.call(req, spider=spider) for req in reqs if req not in start_requests
+                mock.call(req) for req in reqs if req not in start_requests
             ], any_order=True)
         else:
             crawler.engine.crawl.assert_has_calls([
-                mock.call(req, spider=spider) for req in reqs[batch_size:]
+                mock.call(req) for req in reqs[batch_size:]
             ])