Merge pull request #5355 from rmosolgo/master-fix-loads-regression

Use a faster check for loadable?

Author: rmosolgo

lib/graphql/schema/visibility/profile.rb

@@ -256,8 +256,7 @@ def directives
         end
 
         def loadable?(t, _ctx)
-          load_all_types
-          !@all_types[t.graphql_name] && @cached_visible[t]
+          @cached_visible[t] && !referenced?(t)
         end
 
         def loadable_possible_types(t, _ctx)

lib/graphql/schema/warden.rb

@@ -232,7 +232,9 @@ def types
 
       # @return [Boolean] True if this type is used for `loads:` but not in the schema otherwise and not _explicitly_ hidden.
       def loadable?(type, _ctx)
-        !reachable_type_set.include?(type) && visible_type?(type)
+        visible_type?(type) &&
+          !referenced?(type) &&
+          (type.respond_to?(:interfaces) ? interfaces(type).all? { |i| loadable?(i, _ctx) } : true)
       end
 
       def loadable_possible_types(union_type, _ctx)