Merge pull request #5392 from rmosolgo/execution-clean-ups

Remove needless job counting

Author: rmosolgo

lib/graphql/execution/interpreter/runtime.rb

@@ -298,8 +298,6 @@ def evaluate_selections(gathered_selections, selections_result, target_result, r
           end
 
           call_method_on_directives(:resolve, selections_result.graphql_application_value, directives) do
-            finished_jobs = 0
-            enqueued_jobs = gathered_selections.size
             gathered_selections.each do |result_name, field_ast_nodes_or_ast_node|
               # Field resolution may pause the fiber,
               # so it wouldn't get to the `Resolve` call that happens below.
@@ -310,28 +308,19 @@ def evaluate_selections(gathered_selections, selections_result, target_result, r
                   evaluate_selection(
                     result_name, field_ast_nodes_or_ast_node, selections_result
                   )
-                  finished_jobs += 1
-                  if finished_jobs == enqueued_jobs
-                    if target_result
-                      selections_result.merge_into(target_result)
-                    end
-                  end
                   @dataloader.clear_cache
                 }
               else
                 @dataloader.append_job {
                   evaluate_selection(
                     result_name, field_ast_nodes_or_ast_node, selections_result
                   )
-                  finished_jobs += 1
-                  if finished_jobs == enqueued_jobs
-                    if target_result
-                      selections_result.merge_into(target_result)
-                    end
-                  end
                 }
               end
             end
+            if target_result
+              selections_result.merge_into(target_result)
+            end
             selections_result
           end
         end