Skip to content

Commit 3493129

Browse files
committed
Remove steps_to_rerun_after_lazy since it's not used yet
1 parent ba2712d commit 3493129

File tree

3 files changed

+0
-22
lines changed

3 files changed

+0
-22
lines changed

lib/graphql/dataloader.rb

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -65,14 +65,11 @@ def initialize(nonblocking: self.class.default_nonblocking, fiber_limit: self.cl
6565
@nonblocking = nonblocking
6666
end
6767
@fiber_limit = fiber_limit
68-
@steps_to_rerun_after_lazy = []
6968
@lazies_at_depth = nil
7069
end
7170

7271
attr_accessor :lazies_at_depth
7372

74-
attr_reader :steps_to_rerun_after_lazy
75-
7673
# @return [Integer, nil]
7774
attr_reader :fiber_limit
7875

@@ -218,11 +215,6 @@ def run(trace_query_lazy: nil)
218215
run_next_pending_lazies(job_fibers, trace)
219216
run_pending_steps(trace, job_fibers, next_job_fibers, jobs_fiber_limit, source_fibers, next_source_fibers, total_fiber_limit)
220217
end
221-
elsif !@steps_to_rerun_after_lazy.empty?
222-
@pending_jobs.concat(@steps_to_rerun_after_lazy)
223-
f = spawn_job_fiber(trace)
224-
job_fibers << f
225-
@steps_to_rerun_after_lazy.clear
226218
end
227219
end
228220

lib/graphql/dataloader/async_dataloader.rb

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,6 @@ def run(trace_query_lazy: nil)
5353
run_next_pending_lazies(job_fibers, trace)
5454
run_pending_steps(job_fibers, next_job_fibers, source_tasks, jobs_fiber_limit, trace)
5555
end
56-
elsif !@steps_to_rerun_after_lazy.empty?
57-
@pending_jobs.concat(@steps_to_rerun_after_lazy)
58-
f = spawn_job_fiber(trace)
59-
job_fibers << f
60-
@steps_to_rerun_after_lazy.clear
6156
end
6257
end
6358
trace&.end_dataloader(self)

lib/graphql/dataloader/flat_dataloader.rb

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ class FlatDataloader < Dataloader
55
def initialize(*)
66
# TODO unify the initialization lazies_at_depth
77
@lazies_at_depth ||= Hash.new { |h, k| h[k] = [] }
8-
@steps_to_rerun_after_lazy = []
98
@queue = []
109
end
1110

@@ -18,19 +17,12 @@ def run(trace_query_lazy: nil)
1817
run_pending_steps
1918
end
2019
end
21-
22-
if !@steps_to_rerun_after_lazy.empty?
23-
@steps_to_rerun_after_lazy.each(&:call)
24-
@steps_to_rerun_after_lazy.clear
25-
end
2620
end
2721
end
2822

2923
def run_isolated
3024
prev_queue = @queue
31-
prev_stral = @steps_to_rerun_after_lazy
3225
prev_lad = @lazies_at_depth
33-
@steps_to_rerun_after_lazy = []
3426
@queue = []
3527
@lazies_at_depth = @lazies_at_depth.dup&.clear
3628
res = nil
@@ -41,7 +33,6 @@ def run_isolated
4133
res
4234
ensure
4335
@queue = prev_queue
44-
@steps_to_rerun_after_lazy = prev_stral
4536
@lazies_at_depth = prev_lad
4637
end
4738

0 commit comments

Comments
 (0)