Merge pull request #4793 from rmosolgo/action-cable-send-fix

ActionCable: don't use send action

Author: rmosolgo

javascript_client/src/subscriptions/__tests__/createActionCableHandlerTest.ts

@@ -51,14 +51,16 @@ describe("createActionCableHandler", () => {
       {text: "", name: "", id: "abcdef"},
       {},
       {},
-      { onError: () => {}, onNext: () => {}, onCompleted: () => {} }
+      { onError: () => {}, onNext: (result: any) => { log.push(["onNext", result])}, onCompleted: () => { log.push(["onCompleted", null])} }
     )
 
     handlers.connected() // trigger the GraphQL send
+    handlers.received({ result: { data: { a: "1" } }, more: false })
 
     expect(log).toEqual([
-      ["send", { operationId: "client-1/abcdef", operationName: "", query: "", variables: {} }],
       ["execute", { operationId: "client-1/abcdef", operationName: "", query: "", variables: {} }],
+      ["onNext", { data: { a: "1" } }],
+      ["onCompleted", null],
     ])
   })
 })

javascript_client/src/subscriptions/createActionCableHandler.ts

@@ -44,7 +44,6 @@ function createActionCableHandler(options: ActionCableHandlerOptions) {
             operationId: (operation.id && options.clientName ? (options.clientName + "/" + operation.id) : null),
           }
         }
-        channel.perform('send', channelParams)
         channel.perform("execute", channelParams)
       },
       // This result is sent back from ActionCable.