Merge pull request #4799 from rmosolgo/fix-coerce-null

Fix CoercionError handling with null

Author: rmosolgo

lib/graphql/coercion_error.rb

@@ -1,13 +1,5 @@
 # frozen_string_literal: true
 module GraphQL
-  class CoercionError < GraphQL::Error
-    # @return [Hash] Optional custom data for error objects which will be added
-    # under the `extensions` key.
-    attr_accessor :extensions
-
-    def initialize(message, extensions: nil)
-      @extensions = extensions
-      super(message)
-    end
+  class CoercionError < GraphQL::ExecutionError
   end
 end

spec/graphql/schema/scalar_spec.rb

@@ -214,4 +214,33 @@ def self.coerce_result(value, _ctx)
       end
     end
   end
+
+  it "handles coercing null" do
+    class CoerceNullSchema < GraphQL::Schema
+      class CustomScalar < GraphQL::Schema::Scalar
+        class << self
+          def coerce_input(input_value, _context)
+            raise GraphQL::CoercionError, "Invalid value: #{input_value.inspect}"
+          end
+        end
+      end
+
+      class QueryType < GraphQL::Schema::Object
+        field :hello, String do
+          argument :input, CustomScalar, required: false
+        end
+
+        def hello(input: nil)
+          "hello world"
+        end
+      end
+
+      query(QueryType)
+    end
+    result = CoerceNullSchema.execute('{ hello(input: 5) }')
+    assert_equal(["Invalid value: 5"], result["errors"].map { |err| err["message"] })
+
+    null_input_result = CoerceNullSchema.execute('{ hello(input: null) }')
+    assert_equal(["Invalid value: nil"], null_input_result["errors"].map { |err| err["message"] })
+  end
 end