Skip to content

Commit 60bfe00

Browse files
committed
Migrate backtrace error test
1 parent cd333a9 commit 60bfe00

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

spec/graphql/backtrace_spec.rb

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,9 @@ class NilInspectObject
2424
def inspect; nil; end
2525
end
2626

27-
class ErrorInstrumentation
28-
def self.before_query(_query)
29-
end
30-
31-
def self.after_query(query)
27+
module ErrorTrace
28+
def execute_multiplex(multiplex:)
29+
super
3230
raise "Instrumentation Boom"
3331
end
3432
end
@@ -146,7 +144,7 @@ def self.after_query(query)
146144
assert_includes err.message, "\n" + rendered_table
147145
# The message includes the original error message
148146
assert_includes err.message, "This is broken: Boom"
149-
assert_includes err.message, "spec/graphql/backtrace_spec.rb:47", "It includes the original backtrace"
147+
assert_includes err.message, "spec/graphql/backtrace_spec.rb:45", "It includes the original backtrace"
150148
assert_includes err.message, "more lines"
151149
end
152150

@@ -211,7 +209,7 @@ def self.after_query(query)
211209

212210
it "raises original exception instead of a TracedError when error does not occur during resolving" do
213211
instrumentation_schema = Class.new(schema) do
214-
instrument(:query, ErrorInstrumentation)
212+
trace_with(ErrorTrace)
215213
end
216214

217215
assert_raises(RuntimeError) {

0 commit comments

Comments
 (0)