Add a module and spec

Author: rmosolgo

lib/graphql/query/null_context.rb

@@ -21,7 +21,7 @@ def initialize
         @query = NullQuery.new
         @dataloader = GraphQL::Dataloader::NullDataloader.new
         @schema = NullSchema
-        @warden = Schema::Warden::NullWarden.new(nil, context: self, schema: @schema)
+        @warden = Schema::Warden::NullWarden.new(context: self, schema: @schema)
       end
 
       def interpreter?

lib/graphql/schema.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 require "graphql/schema/addition"
+require "graphql/schema/always_visible"
 require "graphql/schema/base_64_encoder"
 require "graphql/schema/find_inherited_value"
 require "graphql/schema/finder"

lib/graphql/schema/always_visible.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+module GraphQL
+  class Schema
+    class AlwaysVisible
+      def self.use(schema, **opts)
+        schema.warden_class = GraphQL::Schema::Warden::NullWarden
+      end
+    end
+  end
+end

lib/graphql/schema/warden.rb

@@ -88,9 +88,8 @@ def arguments(owner, ctx); owner.arguments(ctx); end
       end
 
       class NullWarden
-        def initialize(_filter, context:, schema:)
+        def initialize(_filter = nil, context:, schema:)
           @schema = schema
-          # TODO consider per-query caches even though there's no filtering
         end
 
         def visible_field?(field_defn, _ctx = nil, owner = nil); true; end

spec/graphql/schema/always_visible_spec.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+require "spec_helper"
+
+describe GraphQL::Schema::AlwaysVisible do
+  class AlwaysVisibleSchema < GraphQL::Schema
+    class Query < GraphQL::Schema::Object
+      def self.visible?(ctx)
+        ctx[:visible_was_called] = true
+        false
+      end
+
+      field :one, Integer
+      def one; 1; end
+    end
+    query(Query)
+    use GraphQL::Schema::AlwaysVisible
+  end
+
+  class NotAlwaysVisibleSchema < GraphQL::Schema
+    query(AlwaysVisibleSchema::Query)
+  end
+
+  it "Doesn't call visibility methods" do
+    res = NotAlwaysVisibleSchema.execute("{ one }")
+    assert res.context[:visible_was_called]
+    assert_equal ["Schema is not configured for queries"], res["errors"].map { |err| err["message"] }
+
+    res = AlwaysVisibleSchema.execute("{ one }")
+    refute res.context[:visible_was_called]
+    assert_equal 1, res["data"]["one"]
+  end
+end