Skip to content

Commit 62c0f50

Browse files
authored
Merge pull request #4772 from rmosolgo/fix-enum-values-named-type
Fix enum values named type
2 parents 899ecb3 + 9c0d0e4 commit 62c0f50

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

lib/graphql/language/parser.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ def parse_enum_value_definitions
333333
v_loc = pos
334334
description = if at?(:STRING); string_value; end
335335
defn_loc = pos
336-
enum_value = expect_token_value(:IDENTIFIER)
336+
enum_value = parse_enum_name
337337
v_directives = parse_directives
338338
list << EnumValueDefinition.new(pos: v_loc, definition_pos: defn_loc, description: description, name: enum_value, directives: v_directives, filename: @filename, source_string: @graphql_str)
339339
end

spec/graphql/language/parser_spec.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@
132132
enum Thing {
133133
"VALUE description"
134134
VALUE
135+
type
135136
}
136137
GRAPHQL
137138

@@ -142,6 +143,10 @@
142143
value_defn = thing_defn.values[0]
143144
assert_equal "VALUE", value_defn.name
144145
assert_equal "VALUE description", value_defn.description
146+
147+
value_defn = thing_defn.values[1]
148+
assert_equal "type", value_defn.name
149+
assert_nil value_defn.description
145150
end
146151

147152
it "is parsed for directive definitions" do

0 commit comments

Comments
 (0)