Merge pull request #3959 from rmosolgo/schema-footprint-benchmark

Add 'rake bench:profile_schema_memory_footprint' and work on it

Author: rmosolgo

Rakefile

@@ -116,6 +116,12 @@ namespace :bench do
     prepare_benchmark
     GraphQLBenchmark.profile_batch_loaders
   end
+
+  desc "Check the memory footprint of a large schema"
+  task :profile_schema_memory_footprint do
+    prepare_benchmark
+    GraphQLBenchmark.profile_schema_memory_footprint
+  end
 end
 
 namespace :test do

benchmark/run.rb

@@ -221,4 +221,45 @@ def self.profile_batch_loaders
 
     report.pretty_print
   end
+
+  def self.profile_schema_memory_footprint
+    schema = nil
+    report = MemoryProfiler.report do
+      query_type = Class.new(GraphQL::Schema::Object) do
+        graphql_name "Query"
+        100.times do |i|
+          type = Class.new(GraphQL::Schema::Object) do
+            graphql_name "Object#{i}"
+            field :f, Integer
+          end
+          field "f#{i}", type
+        end
+      end
+
+      thing_type = Class.new(GraphQL::Schema::Object) do
+        graphql_name "Thing"
+        field :name, String
+      end
+
+      mutation_type = Class.new(GraphQL::Schema::Object) do
+        graphql_name "Mutation"
+        100.times do |i|
+          mutation_class = Class.new(GraphQL::Schema::RelayClassicMutation) do
+            graphql_name "Do#{i}"
+            argument :id, "ID"
+            field :thing, thing_type
+            field :things, thing_type.connection_type
+          end
+          field "f#{i}", mutation: mutation_class
+        end
+      end
+
+      schema = Class.new(GraphQL::Schema) do
+        query(query_type)
+        mutation(mutation_type)
+      end
+    end
+
+    report.pretty_print
+  end
 end

lib/graphql/schema/argument.rb

@@ -75,7 +75,10 @@ def initialize(arg_name = nil, type_expr = nil, desc = nil, required: true, type
           end
         end
 
-        self.validates(validates)
+        if validates && !validates.empty?
+          self.validates(validates)
+        end
+
         if required == :nullable
           self.owner.validates(required: { argument: arg_name })
         end

lib/graphql/schema/field.rb

@@ -303,7 +303,9 @@ def initialize(type: nil, name: nil, owner: nil, null: true, description: nil, d
           end
         end
 
-        self.validates(validates)
+        if !validates.empty?
+          self.validates(validates)
+        end
 
         if definition_block
           if definition_block.arity == 1

lib/graphql/schema/object.rb

@@ -98,9 +98,14 @@ def initialize(object, context)
       class << self
         # Set up a type-specific invalid null error to use when this object's non-null fields wrongly return `nil`.
         # It should help with debugging and bug tracker integrations.
-        def inherited(child_class)
-          child_class.const_set(:InvalidNullError, GraphQL::InvalidNullError.subclass_for(child_class))
-          super
+        def const_missing(name)
+          if name == :InvalidNullError
+            custom_err_class = GraphQL::InvalidNullError.subclass_for(self)
+            const_set(:InvalidNullError, custom_err_class)
+            custom_err_class
+          else
+            super
+          end
         end
 
         def kind