Merge pull request #4418 from b1zzu/prometheus-histogram

rmosolgo · web-flow · commit 9c574fccf4b4 · 2023-04-08T08:13:22.000-04:00
Add support for histograms to prometheus_tracing
diff --git a/lib/graphql/tracing/prometheus_tracing/graphql_collector.rb b/lib/graphql/tracing/prometheus_tracing/graphql_collector.rb
@@ -5,7 +5,7 @@ module Tracing
     class PrometheusTracing < PlatformTracing
       class GraphQLCollector < ::PrometheusExporter::Server::TypeCollector
         def initialize
-          @graphql_gauge = PrometheusExporter::Metric::Summary.new(
+          @graphql_gauge = PrometheusExporter::Metric::Base.default_aggregation.new(
             'graphql_duration_seconds',
             'Time spent in GraphQL operations, in seconds'
           )

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ module Tracing`
`5`	`5`	`class PrometheusTracing < PlatformTracing`
`6`	`6`	`class GraphQLCollector < ::PrometheusExporter::Server::TypeCollector`
`7`	`7`	`def initialize`
`8`		`- @graphql_gauge = PrometheusExporter::Metric::Summary.new(`
	`8`	`+ @graphql_gauge = PrometheusExporter::Metric::Base.default_aggregation.new(`
`9`	`9`	`'graphql_duration_seconds',`
`10`	`10`	`'Time spent in GraphQL operations, in seconds'`
`11`	`11`	`)`