Try dynamic visibility ...

Author: rmosolgo

lib/graphql/schema/member/base_dsl_methods.rb

@@ -134,10 +134,6 @@ def default_relay
           false
         end
 
-        def freeze_schema
-          freeze
-        end
-
         protected
 
         attr_writer :default_graphql_name, :graphql_name

lib/graphql/schema/ractor_shareable.rb

@@ -38,6 +38,9 @@ def freeze_schema
           @frozen_directives = Ractor.make_shareable(directives)
 
           Ractor.make_shareable(visibility)
+          visibility.types.each do |_name, type_defn|
+            type_defn.freeze
+          end
           Ractor.make_shareable(introspection_system)
           extend(FrozenMethods)
 

lib/graphql/schema/visibility.rb

@@ -32,6 +32,7 @@ def initialize(schema, dynamic:, preload:, profiles:, migration_errors:)
           Visibility::Profile
         end
         @preload = preload
+        @preloaded = false
         @profiles = profiles
         @cached_profiles = {}
         @dynamic = dynamic
@@ -46,6 +47,7 @@ def initialize(schema, dynamic:, preload:, profiles:, migration_errors:)
       end
 
       def freeze
+        load_all
         @visit = nil
         @interface_type_memberships.default_proc = nil
         @all_references.default_proc = nil
@@ -72,11 +74,17 @@ def get_type(type_name)
         @types[type_name]
       end
 
+      attr_accessor :types
+
       def preload?
         @preload
       end
 
       def preload
+        if @preloaded
+          raise "Invariant: can't preload twice"
+        end
+        @preloaded = true
         # Traverse the schema now (and in the *_configured hooks below)
         # To make sure things are loaded during boot
         @preloaded_types = Set.new
@@ -207,6 +215,7 @@ def ensure_all_loaded(types_to_visit)
       end
 
       def load_all(types: nil)
+        return if frozen?
         if @visit.nil?
           # Set up the visit system
           @interface_type_memberships = Hash.new { |h, interface_type| h[interface_type] = [] }.compare_by_identity

spec/graphql/schema/ractor_shareable_spec.rb

@@ -8,10 +8,8 @@ class Query < GraphQL::Schema::Object
         field :i, Int, fallback_value: 1
       end
       query(Query)
-      validate_timeout(nil) # Timeout doesn't support Ractor yet?
-      use GraphQL::Schema::Visibility, preload: true, dynamic: false, profiles: {
-        nil => {}
-      }
+      validate_timeout(nil) # Timeout doesn't work in non-main Ractors
+      use GraphQL::Schema::Visibility, preload: true, profiles: { nil => {} }
 
       extend GraphQL::Schema::RactorShareable
     end
@@ -24,13 +22,29 @@ class Query < GraphQL::Schema::Object
         result = query.result.to_h
         parent.send(result)
       rescue StandardError => err
+        puts err.message
+        puts err.backtrace
         parent.send(err)
       end
       ractor.send(Ractor.current)
       assert_equal "GraphQL::Query", Ractor.receive
       assert_equal({"data" => {"__typename" => "Query"}}, Ractor.receive)
     end
 
+    it "can get schema members by name" do
+      skip "Doesn't work yet"
+      ractor = Ractor.new do
+        parent = Ractor.receive
+        parent.send(RactorExampleSchema.get_field("Query", "__typename").class.name)
+      rescue StandardError => err
+        puts err.message
+        puts err.backtrace
+        parent.send(err)
+      end
+      ractor.send(Ractor.current)
+      assert_equal "GraphQL::Field", Ractor.receive
+    end
+
     it "can parse a schema string to ast" do
       schema_str = Dummy::Schema.to_definition
       ractor = Ractor.new do