Skip to content

Commit c4f07cd

Browse files
rmosolgormosolgo
authored
Merge pull request #5497 from joelhawksley/erb-fixes
Fix ERB issues surfaced by Herb
2 parents 5503fe7 + 1eceb46 commit c4f07cd

File tree

11 files changed

+17
-15
lines changed

11 files changed

+17
-15
lines changed

‎guides/_layouts/default.html‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
{% else %}
99
<title>GraphQL - {{ page.title }}</title>
1010
{% endif %}
11-
<link href="https://fonts.googleapis.com/css?family=Rubik:300,400,700" rel="stylesheet" />
11+
<link href="https://fonts.googleapis.com/css?family=Rubik:300,400,700" rel="stylesheet">
1212
<link rel="stylesheet" href="{{ site.baseurl }}/css/main.css">
1313
<link rel="icon" href="{{ site.baseurl }}/graphql-ruby-icon.png">
1414
</head>
@@ -51,7 +51,7 @@
5151
<div class="header-container">
5252
<div class="nav">
5353
<a href="{{ site.baseurl }}/" class="img-link">
54-
<img class="graphql-ruby-img" src="{{ site.baseurl }}/graphql-ruby.png" alt="GraphQL Ruby Logo" />
54+
<img class="graphql-ruby-img" src="{{ site.baseurl }}/graphql-ruby.png" alt="GraphQL Ruby Logo">
5555
</a>
5656
<div class="nav-links">
5757
<a href="{{ site.baseurl }}/getting_started">Get Started</a>
@@ -65,7 +65,8 @@
6565
onkeyup="GraphQLRubySearch.run(this)"
6666
type="text"
6767
placeholder="Search the docs..."
68-
/>
68+
autocomplete="off"
69+
>
6970
<a href="#" onclick="event.preventDefault(); detectDarkTheme(true)" class="dark-theme-button"></a>
7071
</div>
7172
</div>

‎guides/_layouts/doc_stub.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!DOCTYPE HTML>
22
<html lang="en">
33
<head>
4-
<meta http-equiv="refresh" content="1;url={{ page.rubydoc_url }}" />
4+
<meta http-equiv="refresh" content="1;url={{ page.rubydoc_url }}">
55
</head>
66
<body>
77
{{ content }}

‎guides/index.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
---
55
<div class="hero">
66
<div class="hero-title">
7-
<img class="graphql-ruby-img" src="{{ site.baseurl }}/graphql-ruby.png" alt="GraphQL Ruby Logo"/>
7+
<img class="graphql-ruby-img" src="{{ site.baseurl }}/graphql-ruby.png" alt="GraphQL Ruby Logo">
88
<h1>GraphQL Ruby</h1>
99
</div>
1010
<div class="hero-subtitle">
@@ -16,7 +16,7 @@ <h1>GraphQL Ruby</h1>
1616
<h2>Install the Gem</h2>
1717
<p>
1818
<a href="{{ site.baseurl}}/getting_started">Get going fast</a> with the <code><a href="https://rubygems.org/gems/graphql">graphql</a></code> gem,
19-
battle-tested and trusted by <a href="https://githubengineering.com/the-github-graphql-api/#open-source">GitHub</a>, <a href="https://www.graphql.com/articles/graphql-at-shopify">Shopify</a>, <a href="https://flexport.com">Flexport</a>, </a><a href="https://www.chime.com">Chime</a>, and <a href="https://www.kickstarter.com/">Kickstarter</a>.
19+
battle-tested and trusted by <a href="https://githubengineering.com/the-github-graphql-api/#open-source">GitHub</a>, <a href="https://www.graphql.com/articles/graphql-at-shopify">Shopify</a>, <a href="https://flexport.com">Flexport</a>, <a href="https://www.chime.com">Chime</a>, and <a href="https://www.kickstarter.com/">Kickstarter</a>.
2020
</p>
2121
{% highlight bash %}
2222
# Download the gem:

‎lib/graphql/dashboard/views/graphql/dashboard/operation_store/clients/_form.html.erb‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,5 @@
2020
<div class="col-auto">
2121
<%= link_to "Back", graphql_dashboard.operation_store_clients_path, class: "btn btn-outline-secondary" %>
2222
</div>
23+
</div>
2324
<% end %>

‎lib/graphql/dashboard/views/graphql/dashboard/operation_store/clients/edit.html.erb‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
<div class="col">
44
<h1>Edit <%= @client.name %></h1>
55
</div>
6-
<div>
6+
</div>
77
<%= render partial: "graphql/dashboard/operation_store/clients/form" %>
88

9-
<hr class="mt-5"/>
9+
<hr class="mt-5">
1010
<div class="row mt-5">
1111
<div class="col">
1212
<div class="alert alert-danger">

‎lib/graphql/dashboard/views/graphql/dashboard/operation_store/clients/index.html.erb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
<td><%= link_to(client.name, graphql_dashboard.edit_operation_store_client_path(name: client.name)) %></td>
3434
<td>
3535
<%= link_to(graphql_dashboard.operation_store_client_operations_path(client_name: client.name)) do %>
36-
<%= client.operations_count %><% if client.archived_operations_count > 0 %> <span class="muted">(<%=client.archived_operations_count%> archived)</span><% end %>
36+
<%= client.operations_count %><% if client.archived_operations_count > 0 %> <span class="muted">(<%= client.archived_operations_count %> archived)</span><% end %>
3737
<% end %>
3838
</td>
3939
<td><%= client.created_at %></td>

‎lib/graphql/dashboard/views/graphql/dashboard/operation_store/clients/new.html.erb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
<div class="col">
44
<h1>New Client</h1>
55
</div>
6-
<div>
6+
</div>
77
<%= render partial: "graphql/dashboard/operation_store/clients/form" %>

‎lib/graphql/dashboard/views/graphql/dashboard/operation_store/index_entries/index.html.erb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<form method="GET" action="<%= graphql_dashboard.operation_store_index_entries_path %>" style="margin-left: auto; margin-top:-5px;">
1111
<div class="input-group">
1212
<%= text_field_tag "q", @search_term, class: "form-control", placeholder: "Find types, fields, arguments, or enum values" %>
13-
<input type="submit" value="Search" class="btn btn-outline-primary btn-sm"/>
13+
<input type="submit" value="Search" class="btn btn-outline-primary btn-sm">
1414
</div>
1515
</form>
1616
</div>

‎lib/graphql/dashboard/views/graphql/dashboard/operation_store/operations/show.html.erb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<% if @operation.nil? %>
33
<div class="row">
44
<div class="col">
5-
<p>No stored operation found for <code><%= params[:digest] %></code>
5+
<p>No stored operation found for <code><%= params[:digest] %></code></p>
66
</div>
77
</div>
88
<% else %>

‎lib/graphql/dashboard/views/graphql/dashboard/subscriptions/topics/show.html.erb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<div class="col">
1010
<p>Last triggered: <%= @topic_last_triggered_at || "none" %></p>
1111
<p><%= pluralize(@subscriptions_count, "Subscription") %></p>
12-
<div>
12+
</div>
1313
</div>
1414

1515
<div class="row">

0 commit comments

Comments
 (0)