Add more tests

Author: rmosolgo

lib/graphql/schema/argument.rb

@@ -297,7 +297,12 @@ def coerce_into_values(parent_object, values, context, argument_values)
 
       # @api private
       def validate_default_value
-        coerced_default_value = type.coerce_isolated_result(default_value) unless default_value.nil?
+        coerced_default_value = begin
+          type.coerce_isolated_result(default_value) unless default_value.nil?
+        rescue GraphQL::Schema::Enum::UnresolvedValueError
+          # It raises this, which is helpful at runtime, but not here...
+          default_value
+        end
         res = type.valid_isolated_input?(coerced_default_value)
         if !res
           raise InvalidDefaultValueError.new(self)

spec/graphql/schema/argument_spec.rb

@@ -415,9 +415,51 @@ class InvalidLazyArgumentObject < GraphQL::Schema::Object
       assert_equal expected_message, err.message
     end
 
-    it "TODO: raises when input argument default values are invalid"
+    it "raises when input argument default values are invalid" do
+      input_obj = Class.new(GraphQL::Schema::InputObject) do
+        graphql_name "InputObj"
+        argument :arg1, [String, null: false], default_value: [nil], required: false
+      end
+
+      query_type = Class.new(GraphQL::Schema::Object) do
+        graphql_name "Query"
+        field :f1, Integer, null: false do
+          argument :input, input_obj, required: true
+        end
+      end
+
+      err = assert_raises GraphQL::Schema::Argument::InvalidDefaultValueError do
+        Class.new(GraphQL::Schema) do
+          query(query_type)
+        end
+      end
+
+      expected_message = "`InputObj.arg1` has an invalid default value: `[nil]` isn't accepted by `[String!]`; update the default value or the argument type."
+      assert_equal expected_message, err.message
+    end
+
+    it "raises when directive argument default values are invalid" do
+      lang = Class.new(GraphQL::Schema::Enum) do
+        graphql_name "Language"
+        value "EN"
+        value "JA"
+      end
+
+      localize = Class.new(GraphQL::Schema::Directive) do
+        graphql_name "localize"
+        locations GraphQL::Schema::Directive::FIELD
+        argument :lang, lang, default_value: "ZH", required: false
+      end
+
+      err = assert_raises GraphQL::Schema::Argument::InvalidDefaultValueError do
+        Class.new(GraphQL::Schema) do
+          directive(localize)
+        end
+      end
 
-    it "TODO: raises when directive argument default values are invalid"
+      expected_message = "`@localize.lang` has an invalid default value: `\"ZH\"` isn't accepted by `Language`; update the default value or the argument type."
+      assert_equal expected_message, err.message
+    end
 
     it "raises when parsing a schema from a string" do
       schema_str = <<-GRAPHQL
@@ -431,6 +473,42 @@ class InvalidLazyArgumentObject < GraphQL::Schema::Object
       end
       expected_message = "`Query.f1.arg1` has an invalid default value: `nil` isn't accepted by `Int!`; update the default value or the argument type."
       assert_equal expected_message, err.message
+
+      directive_schema_str = <<-GRAPHQL
+      enum Language {
+        EN
+        JA
+      }
+      directive @localize(lang: Language = "ZH") on FIELD
+
+      type Query {
+        f1: Int
+      }
+      GRAPHQL
+
+
+      err2 = assert_raises GraphQL::Schema::Argument::InvalidDefaultValueError do
+        GraphQL::Schema.from_definition(directive_schema_str)
+      end
+      expected_message = "`@localize.lang` has an invalid default value: `\"ZH\"` isn't accepted by `Language`; update the default value or the argument type."
+      assert_equal expected_message, err2.message
+
+      input_obj_schema_str = <<-GRAPHQL
+      input InputObj {
+        arg1: [String!] = [null]
+      }
+
+      type Query {
+        f1(arg1: InputObj): Int
+      }
+      GRAPHQL
+
+
+      err3 = assert_raises GraphQL::Schema::Argument::InvalidDefaultValueError do
+        GraphQL::Schema.from_definition(input_obj_schema_str)
+      end
+      expected_message = "`InputObj.arg1` has an invalid default value: `[nil]` isn't accepted by `[String!]`; update the default value or the argument type."
+      assert_equal expected_message, err3.message
     end
   end
 end