Merge pull request #1793 from rmosolgo/fix-replace-inline-fragment

Fix modifying fragment spreads with visitor

Author: Robert Mosolgo

lib/graphql/language/nodes.rb

@@ -375,6 +375,11 @@ def children_method_name
       class FragmentSpread < AbstractNode
         scalar_methods :name
         children_methods(directives: GraphQL::Language::Nodes::Directive)
+
+        def children_method_name
+          :selections
+        end
+
         # @!attribute name
         #   @return [String] The identifier of the fragment to apply, corresponds with {FragmentDefinition#name}
       end
@@ -387,6 +392,10 @@ class InlineFragment < AbstractNode
           directives: GraphQL::Language::Nodes::Directive,
         })
 
+        def children_method_name
+          :selections
+        end
+
         # @!attribute type
         #   @return [String, nil] Name of the type this fragment applies to, or `nil` if this fragment applies to any type
       end

spec/graphql/language/visitor_spec.rb

@@ -184,6 +184,25 @@ def on_directive(node, parent)
           super
         end
       end
+
+      def on_inline_fragment(node, parent)
+        if node.selections.map(&:name) == ["renameFragmentField", "spread"]
+          _field, spread = node.selections
+          new_node = node.merge(selections: [GraphQL::Language::Nodes::Field.new(name: "renamed"), spread])
+          super(new_node, parent)
+        else
+          super(node, parent)
+        end
+      end
+
+      def on_fragment_spread(node, parent)
+        if node.name == "spread"
+          new_node = node.merge(name: "renamedSpread")
+          super(new_node, parent)
+        else
+          super(node, parent)
+        end
+      end
     end
 
     def get_result(query_str)
@@ -298,6 +317,30 @@ def get_result(query_str)
   }
   anotherAddition(addedArgument: 1) @doStuff(addedArgument2: 2)
 }
+GRAPHQL
+
+      document, new_document = get_result(before_query)
+      assert_equal before_query, document.to_query_string
+      assert_equal after_query, new_document.to_query_string
+    end
+
+    it "can modify inline fragments" do
+      before_query = <<-GRAPHQL.chop
+query {
+  ... on Query {
+    renameFragmentField
+    ...spread
+  }
+}
+GRAPHQL
+
+      after_query = <<-GRAPHQL.chop
+query {
+  ... on Query {
+    renamed
+    ...renamedSpread
+  }
+}
 GRAPHQL
 
       document, new_document = get_result(before_query)