-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Description
Describe the bug
Lots of unexpected deprecation warning messages "XXX is deprecated; Use dataloader.run instead."
e.g.
GraphQL::Execution::Interpreter::Resolve.resolve_all is deprecated; Use `dataloader.run` instead.
/Users/cyrux.wong/.rbenv/versions/3.4.6/lib/ruby/gems/3.4.0/gems/graphql-enterprise-1.5.7/lib/graphql/enterprise/object_cache.rb:652:in 'block in GraphQL::Enterprise::ObjectCache::Trace.update_cache_and_populate_cached_results'
/Users/cyrux.wong/.rbenv/versions/3.4.6/lib/ruby/gems/3.4.0/gems/graphql-2.5.12/lib/graphql/dataloader.rb:352:in 'block in GraphQL::Dataloader#spawn_job_fiber'
/Users/cyrux.wong/.rbenv/versions/3.4.6/lib/ruby/gems/3.4.0/gems/graphql-2.5.12/lib/graphql/dataloader.rb:254:in 'block in GraphQL::Dataloader#spawn_fiber'
It introduces >1M warning log entries to our system every day.
Versions
graphql version: 2.5.12
rails (or other framework): 8.0.2.1
graphql-pro version: 1.29.12
graphql-enterprise version: 1.5.7 (Object cache enabled)
GraphQL schema
Every schema with object cache enabled will have the issue.
GraphQL query
Every query with object cache enabled will have the issue.
Steps to reproduce
Executing any query with object cache enabled. View the log file.
Expected behavior
One of the following:
- Do not print the deprecation warning to the log.
- Print many fewer entries.
- Have a configuration to allow us to skip this specific warning message.
Actual behavior
The warning messages are printed multiple times for each query.
Additional context
As a quick fix, I reverted graphql gem to version: 2.5.11