Skip to content

Commit 49eaae6

Browse files
authored
Merge pull request #19 from rmrs/bugfix-android-compile-warning-glide-4-9-0
Fix Android "Configuration 'compile' is obsolete" warning
2 parents a598939 + 57cf3f7 commit 49eaae6

File tree

3 files changed

+16
-12
lines changed

3 files changed

+16
-12
lines changed

.vscode/settings.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
22
"javascript.preferences.quoteStyle": "single",
3-
"editor.formatOnSave": false
3+
"editor.formatOnSave": false,
4+
"java.configuration.updateBuildConfiguration": "disabled"
45
}

android/build.gradle

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
def safeExtGet(prop, fallback) {
2+
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
3+
}
14

25
buildscript {
36
repositories {
@@ -12,12 +15,12 @@ buildscript {
1215
apply plugin: 'com.android.library'
1316

1417
android {
15-
compileSdkVersion 26
16-
buildToolsVersion "25.0.3"
18+
compileSdkVersion safeExtGet('compileSdkVersion', 26)
19+
buildToolsVersion safeExtGet('buildToolsVersion', "25.0.3")
1720

1821
defaultConfig {
19-
minSdkVersion 16
20-
targetSdkVersion 26
22+
minSdkVersion safeExtGet('minSdkVersion', 16)
23+
targetSdkVersion safeExtGet('targetSdkVersion', 26)
2124
versionCode 1
2225
versionName "1.0"
2326
}
@@ -34,18 +37,18 @@ repositories {
3437
}
3538

3639
dependencies {
37-
compile 'com.facebook.react:react-native:+'
40+
implementation 'com.facebook.react:react-native:+'
3841

3942
// glide dependencies
40-
compile 'com.github.bumptech.glide:glide:4.2.0'
41-
annotationProcessor 'com.github.bumptech.glide:compiler:4.2.0'
43+
implementation 'com.github.bumptech.glide:glide:4.9.0'
44+
annotationProcessor 'com.github.bumptech.glide:compiler:4.9.0'
4245

4346
// FirebaseUI Storage only
44-
compile 'com.firebaseui:firebase-ui-storage:3.0.0'
47+
implementation 'com.firebaseui:firebase-ui-storage:3.0.0'
4548

4649
// PhotoView
47-
compile 'com.github.chrisbanes:PhotoView:2.1.3'
50+
implementation 'com.github.chrisbanes:PhotoView:2.1.3'
4851

4952
// glide-transformations
50-
compile 'jp.wasabeef:glide-transformations:3.0.1'
53+
implementation 'jp.wasabeef:glide-transformations:3.0.1'
5154
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-native-firebaseui",
3-
"version": "v0.1.1",
3+
"version": "v0.1.2",
44
"description": "React Native Firebase Bindings Based on FirebaseUI SDK",
55
"main": "index.js",
66
"repository": {

0 commit comments

Comments
 (0)