Skip to content

Commit d0f8bb4

Browse files
committed
Fixed Archive not working on XCode
The biggest issue was with the Framework search paths, which should not have been there
1 parent 3b7d792 commit d0f8bb4

File tree

3 files changed

+4
-16
lines changed

3 files changed

+4
-16
lines changed

ios/FirebaseUIImageView.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// Copyright © 2017 Rumors. All rights reserved.
77
//
88

9-
#import "Firebase.h"
9+
#import <FirebaseStorage/FirebaseStorage.h>
1010

1111
#import <React/RCTResizeMode.h>
1212

ios/FirebaseUIImageView.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99

1010
#import "FirebaseUIImageView.h"
11-
#import "Firebase.h"
11+
#import <FirebaseStorage/FirebaseStorage.h>
1212
#import "UIImageView+FirebaseStorage.h"
1313

1414
@implementation FirebaseImageView

ios/RNFirebaseUi.xcodeproj/project.pbxproj

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -209,19 +209,13 @@
209209
isa = XCBuildConfiguration;
210210
buildSettings = {
211211
CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES;
212-
FRAMEWORK_SEARCH_PATHS = (
213-
"$(inherited)",
214-
"${BUILT_PRODUCTS_DIR}",
215-
"${PROJECT_DIR}/../../../ios/Pods/**",
216-
);
217212
HEADER_SEARCH_PATHS = (
218213
"$(inherited)",
219214
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include,
220215
"$(SRCROOT)/../../../React/**",
221216
"$(SRCROOT)/../../react-native/React/**",
222-
"${SRCROOT}/../../../ios/Pods/**",
217+
"${SRCROOT}/../../../ios/Pods/Headers/Public",
223218
);
224-
LIBRARY_SEARCH_PATHS = "$(inherited)";
225219
OTHER_LDFLAGS = "-ObjC";
226220
PRODUCT_NAME = RNFirebaseUi;
227221
SKIP_INSTALL = YES;
@@ -232,19 +226,13 @@
232226
isa = XCBuildConfiguration;
233227
buildSettings = {
234228
CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES;
235-
FRAMEWORK_SEARCH_PATHS = (
236-
"$(inherited)",
237-
"${BUILT_PRODUCTS_DIR}",
238-
"${PROJECT_DIR}/../../../ios/Pods/**",
239-
);
240229
HEADER_SEARCH_PATHS = (
241230
"$(inherited)",
242231
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include,
243232
"$(SRCROOT)/../../../React/**",
244233
"$(SRCROOT)/../../react-native/React/**",
245-
"${SRCROOT}/../../../ios/Pods/**",
234+
"${SRCROOT}/../../../ios/Pods/Headers/Public",
246235
);
247-
LIBRARY_SEARCH_PATHS = "$(inherited)";
248236
OTHER_LDFLAGS = "-ObjC";
249237
PRODUCT_NAME = RNFirebaseUi;
250238
SKIP_INSTALL = YES;

0 commit comments

Comments
 (0)