Skip to content

Commit 1d11d55

Browse files
Fix filter_linkages example error and drop oldrel-1 from CI
Use .data$ pronoun for NSE bindings in filter_linkages() to fix R CMD check NOTE. Regenerate docs to sync stale man page (p_value → p_adjusted). Drop oldrel-1 from CI matrix since ggrepel now requires R >= 4.5.0. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 173e631 commit 1d11d55

File tree

4 files changed

+19
-12
lines changed

4 files changed

+19
-12
lines changed

.github/workflows/R-CMD-check.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ jobs:
2222
config:
2323
- {os: ubuntu-latest, r: 'devel', http-user-agent: 'release'}
2424
- {os: ubuntu-latest, r: 'release'}
25-
- {os: ubuntu-latest, r: 'oldrel-1'}
2625

2726
env:
2827
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}

R/odds-ratios.R

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,11 +81,15 @@ clean_odds_ratios <- function(data, cap_inf = 2) {
8181
filter_linkages <- function(data, max_p = 0.01, min_obs = 100, min_lor = 1.0) {
8282
data |>
8383
dplyr::filter(
84-
p_adjusted < max_p,
85-
total_obs >= min_obs,
86-
abs(log_odds_ratio) >= min_lor
84+
.data$p_adjusted < max_p,
85+
.data$total_obs >= min_obs,
86+
abs(.data$log_odds_ratio) >= min_lor
8787
) |>
88-
dplyr::transmute(pos1, pos2, value = log_odds_ratio)
88+
dplyr::transmute(
89+
pos1 = .data$pos1,
90+
pos2 = .data$pos2,
91+
value = .data$log_odds_ratio
92+
)
8993
}
9094

9195
#' Aggregate odds ratios to isodecoder level.

man/clover-package.Rd

Lines changed: 6 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/filter_linkages.Rd

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)