Skip to content
This repository was archived by the owner on Jun 10, 2021. It is now read-only.

Commit d43f125

Browse files
committed
Fixed the NEW_SERVER_PORT property to use the value entered by the user. Fixed a typo in CustomActions.
1 parent caf4676 commit d43f125

File tree

4 files changed

+11
-4
lines changed

4 files changed

+11
-4
lines changed

build_/win/CustomActions/CustomActions/CustomAction.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ public static ActionResult CheckServerPort(Session session)
328328
}
329329
else
330330
{
331-
session.Log("Port {0} is in free.", port);
331+
session.Log("Port {0} is free.", port);
332332
session[HawkCDServerProperties.IsDeafultServerPortInUse] = "0";
333333
}
334334

build_/win/Installers/HawkCD_Server.msifact

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -804,7 +804,7 @@ You can choose not to install [ProductName] by clicking Cancel to exit.
804804
<Fragment>
805805
<UI>
806806
<Dialog Id="HostNameDlg" Width="370" Height="270" Title="!(loc.InstallDirDlg_Title)">
807-
<Control Id="Control_1" Property="NEW_EDIT_PROPERTY" Type="Edit" X="10" Y="130" Width="150" Height="20">
807+
<Control Id="Control_1" Property="NEW_SERVER_PORT" Type="Edit" X="10" Y="130" Width="150" Height="20">
808808
<Condition Action="hide">IS_DEFAULT_SERVER_PORT_IN_USE = 0</Condition>
809809
<Condition Action="show">IS_DEFAULT_SERVER_PORT_IN_USE = 1</Condition>
810810
</Control>
@@ -1824,6 +1824,11 @@ You can choose not to install [ProductName] by clicking Cancel to exit.
18241824
<CustomAction Type="2" ID="LaunchJavaDownloadPage" Impersonate="yes" Return="0" SuppressModularization="no" TerminalServerAware="no" HideTarget="no" Execute="immediate" Location="3" FileName="" FileID="" PropertyName="" FullPath="[SystemFolder]cmd.exe" WorkingFolder="SystemFolder" CommandLineArguments="/c start explorer &quot;http://www.oracle.com/technetwork/java/javase/downloads/jre8-downloads-2133155.html&quot;">
18251825
<CustomTimingList/>
18261826
</CustomAction>
1827+
<CustomAction Type="6" ID="UpdateServerShortcutUrlProp" Impersonate="yes" Return="2" SuppressModularization="no" TerminalServerAware="no" HideTarget="no" Execute="immediate" Property="SERVER_SHORTCUT_URL" Value="http://localhost:[NEW_SERVER_PORT]/">
1828+
<CustomTimingList>
1829+
<CustomTiming Sequence="4" Execute="0" Exit="0" RelativeAction="InstallInitialize" SequenceNumber="0" Condition="IS_DEFAULT_SERVER_PORT_IN_USE = 1"/>
1830+
</CustomTimingList>
1831+
</CustomAction>
18271832
</CustomActions>
18281833
<MediaItems>
18291834
<MediaItem ID="1" DiskPrompt="Disk 1" Type="0" CompressionLevel="3" EmbedCabInMSI="yes" CabFilename="setup.cab" OutputSubFolder="" VolumeLabel=""/>

build_/win/Installers/Wix_Server/WiX/HawkCD_Server.wxs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version='1.0'?>
22
<!-- Created with MSI Factory version 2.1.1011.0
3-
on 2016-10-31 at 21:25:03 -->
3+
on 2016-11-06 at 11:00:05 -->
44
<?include BuildVars.wxi?>
55
<Wix xmlns="http://schemas.microsoft.com/wix/2006/wi">
66
<Product Id="$(var.ProductBuildGUID)" Name="HawkCD Server - $(var.BuildNumber) - Alpha" Version="$(var.BuildNumber)" Manufacturer="RnD Solutions Ltd." UpgradeCode="EC3C72CC-B52F-4A00-A632-595710B93D88" Language="1033">
@@ -72,6 +72,7 @@
7272
<CustomAction Id="CheckServerPort" Impersonate="yes" Return="ignore" Execute="immediate" BinaryKey="CustomActions.CA.dll" DllEntry="CheckServerPort"/>
7373
<CustomAction Id="CheckIsUserAdministrator" Impersonate="yes" Return="check" Execute="immediate" BinaryKey="CustomActions.CA.dll" DllEntry="CheckIsUserAdministrator"/>
7474
<CustomAction Id="LaunchJavaDownloadPage" Impersonate="yes" Return="asyncNoWait" Execute="immediate" ExeCommand="[SystemFolder]cmd.exe /c start explorer &quot;http://www.oracle.com/technetwork/java/javase/downloads/jre8-downloads-2133155.html&quot;" Directory="SystemFolder"/>
75+
<CustomAction Id="UpdateServerShortcutUrlProp" Impersonate="yes" Return="check" Execute="immediate" Property="SERVER_SHORTCUT_URL" Value="http://localhost:[NEW_SERVER_PORT]/"/>
7576
<Binary Id="CustomActions.CA.dll" SourceFile="$(var.Buildzone)\CustomActions\CustomActions\bin\Debug\CustomActions.CA.dll"/>
7677
<InstallExecuteSequence>
7778
<Custom Action="InstallRedis" After="InstallFinalize">NOT REMOVE~="ALL" </Custom>
@@ -89,6 +90,7 @@
8990
<Custom Action="UpdateRedisConfig" Before="InstallRedis">NOT REMOVE~="ALL" AND NOT OLDERVERSIONBEINGUPGRADED</Custom>
9091
<Custom Action="CheckServerPort" Before="AppSearch">1</Custom>
9192
<Custom Action="CheckIsUserAdministrator" Before="AppSearch">1</Custom>
93+
<Custom Action="UpdateServerShortcutUrlProp" Before="InstallInitialize">IS_DEFAULT_SERVER_PORT_IN_USE = 1</Custom>
9294
</InstallExecuteSequence>
9395
<InstallUISequence>
9496
<Custom Action="DetectJava" Before="AppSearch">1</Custom>

build_/win/Installers/Wix_Server/WiX/msifactui.wxs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -505,7 +505,7 @@ You can choose not to install [ProductName] by clicking Cancel to exit.
505505
<Fragment>
506506
<UI>
507507
<Dialog Id="HostNameDlg" Width="370" Height="270" Title="!(loc.InstallDirDlg_Title)">
508-
<Control Id="Control_1" Property="NEW_EDIT_PROPERTY" Type="Edit" X="10" Y="130" Width="150" Height="20">
508+
<Control Id="Control_1" Property="NEW_SERVER_PORT" Type="Edit" X="10" Y="130" Width="150" Height="20">
509509
<Condition Action="hide">IS_DEFAULT_SERVER_PORT_IN_USE = 0</Condition>
510510
<Condition Action="show">IS_DEFAULT_SERVER_PORT_IN_USE = 1</Condition>
511511
</Control>

0 commit comments

Comments
 (0)