Skip to content

Commit 0da63af

Browse files
committed
v1.0 - breaking change to require paths, which requires jQuery UI >=1.12, if consuming via AMD/CommonJS (or config changes to normalize paths)
1 parent 8de0027 commit 0da63af

File tree

5 files changed

+15266
-11473
lines changed

5 files changed

+15266
-11473
lines changed

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,11 +110,10 @@ This library also includes a `draggable` binding that you can place on single it
110110

111111
* Knockout 2.0+
112112
* jQuery - no specific version identified yet as minimum
113-
* jQuery UI - no specific version identfied yet as minimum
113+
* jQuery UI - If needing AMD/CommonJS support, then it requires >=1.12 (or ensuring that paths are mapped via config properly - it looks for `jquery-ui/ui/widgets/sortable` and `jquery-ui/ui/widgets/draggable`)
114114

115115
**Touch Support** - for touch support take a look at: http://touchpunch.furf.com/
116116

117-
118117
**Build:** This project uses [grunt](http://gruntjs.com/) for building/minifying.
119118

120119
**Examples** The `examples` directory contains samples that include a simple sortable list, connected lists, and a seating chart that takes advantage of many of the additional options.

build/knockout-sortable.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
// knockout-sortable 0.15.0 | (c) 2016 Ryan Niemeyer | http://www.opensource.org/licenses/mit-license
1+
// knockout-sortable 1.0.0 | (c) 2016 Ryan Niemeyer | http://www.opensource.org/licenses/mit-license
22
;(function(factory) {
33
if (typeof define === "function" && define.amd) {
44
// AMD anonymous module
5-
define(["knockout", "jquery", "jquery-ui/sortable", "jquery-ui/draggable"], factory);
5+
define(["knockout", "jquery", "jquery-ui/ui/widgets/sortable", "jquery-ui/ui/widgets/draggable"], factory);
66
} else if (typeof require === "function" && typeof exports === "object" && typeof module === "object") {
77
// CommonJS module
88
var ko = require("knockout"),
99
jQuery = require("jquery");
10-
require("jquery-ui/sortable");
11-
require("jquery-ui/draggable");
10+
require("jquery-ui/ui/widgets/sortable");
11+
require("jquery-ui/ui/widgets/draggable");
1212
factory(ko, jQuery);
1313
} else {
1414
// No module loader (plain <script> tag) - put directly in global namespace

build/knockout-sortable.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)