Deploy more RetainPtr in WebKit to prepare for the next LLVM update

https://bugs.webkit.org/show_bug.cgi?id=299281

Reviewed by NOBODY (OOPS!).

Deploy more RetainPtr to prepare WebKit for the next LLVM update for:
llvm/llvm-project#160569

No new tests since there should be no behavioral change.

Author: rniwa

Source/WebKit/NetworkProcess/CustomProtocols/Cocoa/LegacyCustomProtocolManagerCocoa.mm

@@ -185,7 +185,7 @@ static inline void dispatchOnInitializationRunLoop(WKCustomProtocol* protocol, v
     RetainPtr<NSError> nsError = error.nsError();
 
     dispatchOnInitializationRunLoop(protocol.get(), ^ {
-        [[protocol client] URLProtocol:protocol.get() didFailWithError:nsError.get()];
+        [retainPtr([protocol client]) URLProtocol:protocol.get() didFailWithError:nsError.get()];
     });
 
     removeCustomProtocol(customProtocolID);
@@ -200,7 +200,7 @@ static inline void dispatchOnInitializationRunLoop(WKCustomProtocol* protocol, v
     RetainPtr nsData = toNSData(data);
 
     dispatchOnInitializationRunLoop(protocol.get(), ^ {
-        [[protocol client] URLProtocol:protocol.get() didLoadData:nsData.get()];
+        [retainPtr([protocol client]) URLProtocol:protocol.get() didLoadData:nsData.get()];
     });
 }
 
@@ -213,7 +213,7 @@ static inline void dispatchOnInitializationRunLoop(WKCustomProtocol* protocol, v
     RetainPtr<NSURLResponse> nsResponse = response.nsURLResponse();
 
     dispatchOnInitializationRunLoop(protocol.get(), ^ {
-        [[protocol client] URLProtocol:protocol.get() didReceiveResponse:nsResponse.get() cacheStoragePolicy:toNSURLCacheStoragePolicy(cacheStoragePolicy)];
+        [retainPtr([protocol client]) URLProtocol:protocol.get() didReceiveResponse:nsResponse.get() cacheStoragePolicy:toNSURLCacheStoragePolicy(cacheStoragePolicy)];
     });
 }
 
@@ -224,7 +224,7 @@ static inline void dispatchOnInitializationRunLoop(WKCustomProtocol* protocol, v
         return;
 
     dispatchOnInitializationRunLoop(protocol.get(), ^ {
-        [[protocol client] URLProtocolDidFinishLoading:protocol.get()];
+        [retainPtr([protocol client]) URLProtocolDidFinishLoading:protocol.get()];
     });
 
     removeCustomProtocol(customProtocolID);
@@ -240,7 +240,7 @@ static inline void dispatchOnInitializationRunLoop(WKCustomProtocol* protocol, v
     RetainPtr<NSURLResponse> nsRedirectResponse = redirectResponse.nsURLResponse();
 
     dispatchOnInitializationRunLoop(protocol.get(), [protocol, nsRequest, nsRedirectResponse]() {
-        [[protocol client] URLProtocol:protocol.get() wasRedirectedToRequest:nsRequest.get() redirectResponse:nsRedirectResponse.get()];
+        [retainPtr([protocol client]) URLProtocol:protocol.get() wasRedirectedToRequest:nsRequest.get() redirectResponse:nsRedirectResponse.get()];
     });
 }
 

Source/WebKit/NetworkProcess/Downloads/cocoa/WKDownloadProgress.mm

@@ -273,7 +273,7 @@ - (void)_updateProgressExtendedAttributeOnProgressFile
     float fraction = (total > 0) ? (float)completed / (float)total : -1;
     auto xattrContents = adoptNS([[NSString alloc] initWithFormat:@"%.3f", fraction]);
 
-    setxattr(self.fileURL.fileSystemRepresentation, "com.apple.progress.fractionCompleted", xattrContents.get().UTF8String, [xattrContents.get() lengthOfBytesUsingEncoding:NSUTF8StringEncoding], 0, 0);
+    setxattr(RetainPtr { self.fileURL }.get().fileSystemRepresentation, "com.apple.progress.fractionCompleted", xattrContents.get().UTF8String, [xattrContents.get() lengthOfBytesUsingEncoding:NSUTF8StringEncoding], 0, 0);
 }
 
 - (void)dealloc

Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm

@@ -175,7 +175,7 @@ static float toNSURLSessionTaskPriority(WebCore::ResourceLoadPriority priority)
 
     CheckedPtr session = networkSession();
     auto cnameDomain = [this]() {
-        if (RetainPtr lastResolvedCNAMEInChain = [[m_task _resolvedCNAMEChain] lastObject])
+        if (RetainPtr lastResolvedCNAMEInChain = [retainPtr([m_task _resolvedCNAMEChain]) lastObject])
             return lastCNAMEDomain(lastResolvedCNAMEInChain.get());
         return WebCore::RegistrableDomain { };
     }();
@@ -420,7 +420,7 @@ static float toNSURLSessionTaskPriority(WebCore::ResourceLoadPriority priority)
     if (isTopLevelNavigation())
         updateFirstPartyInfoForSession(response.url());
 #if ENABLE(NETWORK_ISSUE_REPORTING)
-    else if (NetworkIssueReporter::shouldReport([m_task _incompleteTaskMetrics])) {
+    else if (NetworkIssueReporter::shouldReport(RetainPtr { [m_task _incompleteTaskMetrics] }.get())) {
         if (CheckedPtr session = networkSession())
             session->reportNetworkIssue(*m_webPageProxyID, firstRequest().url());
     }
@@ -585,7 +585,7 @@ static float toNSURLSessionTaskPriority(WebCore::ResourceLoadPriority priority)
 {
     if (!m_suggestedFilename.isEmpty())
         return m_suggestedFilename;
-    return m_task.get().response.suggestedFilename;
+    return RetainPtr { m_task.get().response }.get().suggestedFilename;
 }
 
 void NetworkDataTaskCocoa::cancel()
@@ -668,7 +668,8 @@ static float toNSURLSessionTaskPriority(WebCore::ResourceLoadPriority priority)
 
 WebCore::Credential serverTrustCredential(const WebCore::AuthenticationChallenge& challenge)
 {
-    return WebCore::Credential([NSURLCredential credentialForTrust: RetainPtr { challenge.protectedNSURLAuthenticationChallenge().get().protectionSpace.serverTrust }.get()]);
+    auto protectionSpace = retainPtr(challenge.protectedNSURLAuthenticationChallenge().get().protectionSpace);
+    return WebCore::Credential([NSURLCredential credentialForTrust: RetainPtr { protectionSpace.get().serverTrust }.get()]);
 }
 
 String NetworkDataTaskCocoa::description() const