Fix Symfony File::move() (#46)

Author: tarampampam

CHANGELOG.md

@@ -4,6 +4,14 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog][keepachangelog] and this project adheres to [Semantic Versioning][semver].
 
+## UNRELEASED
+
+### Fixed
+
+- Symfony uploaded file moving (`FixSymfonyFileMovingListener` was added for this) [#43]
+
+[#43]:https://github.com/spiral/roadrunner-laravel/issues/43
+
 ## v5.0.0
 
 ### Added

composer.json

@@ -1,7 +1,7 @@
 {
     "name": "spiral/roadrunner-laravel",
     "type": "library",
-    "description": "RoadRunner bridge for Laravel applications",
+    "description": "RoadRunner: Bridge for Laravel applications",
     "keywords": [
         "laravel",
         "bridge",

fixes/fix-symfony-file-moving.php

@@ -0,0 +1,36 @@
+<?php
+
+namespace Symfony\Component\HttpFoundation\File {
+
+    /**
+     * ***************************************************************************
+     * ******* WARNING **** WARNING **** WARNING **** WARNING **** WARNING *******.
+     * ***************************************************************************
+     * *******                                                             *******
+     * *******        THIS FUNCTION OVERLOADING IS NECESSARY MEASURE       *******
+     * *******    https://github.com/spiral/roadrunner-laravel/issues/43   *******
+     * *******                                                             *******
+     * ***************************************************************************.
+     *
+     * Moves an uploaded file to a new location.
+     *
+     * @link  https://php.net/manual/en/function.move-uploaded-file.php
+     *
+     * @param string $from The filename of the uploaded file
+     * @param string $to   The destination of the moved file
+     *
+     * @return bool If filename is a valid file, but cannot be moved for some
+     *              reason, no action will occur, and will return false.
+     *
+     * @see   \Symfony\Component\HttpFoundation\File\UploadedFile::move
+     *
+     * @since 4.0.3
+     * @since 5.0
+     * @since 7.0
+     * @since 8.0
+     */
+    function move_uploaded_file(string $from, string $to): bool
+    {
+        return \is_file($from) && \rename($from, $to);
+    }
+}

fixes/fix-symfony-file-validation.php

@@ -13,19 +13,22 @@
      * *******                                                             *******
      * ***************************************************************************.
      *
-     * @see \Symfony\Component\HttpFoundation\File\UploadedFile::isValid
-     *
      * Tells whether the file was uploaded via HTTP POST.
+     *
      * @link  https://php.net/manual/en/function.is-uploaded-file.php
      *
      * @param string $filename The filename being checked
      *
      * @return bool always true
      *
+     * @see   \Symfony\Component\HttpFoundation\File\UploadedFile::isValid
+     *
      * @since 4.0.3
      * @since 5.0
+     * @since 7.0
+     * @since 8.0
      */
-    function is_uploaded_file($filename)
+    function is_uploaded_file(string $filename): bool
     {
         return true;
     }

src/Defaults.php

@@ -15,6 +15,7 @@ public static function beforeLoopStarted(): array
     {
         return [
             Listeners\FixSymfonyFileValidationListener::class,
+            Listeners\FixSymfonyFileMovingListener::class,
             Listeners\WarmInstancesListener::class,
         ];
     }

src/Listeners/FixSymfonyFileMovingListener.php

@@ -0,0 +1,21 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Spiral\RoadRunnerLaravel\Listeners;
+
+/**
+ * @link https://github.com/spiral/roadrunner-laravel/issues/43
+ */
+class FixSymfonyFileMovingListener implements ListenerInterface
+{
+    /**
+     * {@inheritdoc}
+     */
+    public function handle($event): void
+    {
+        if (!\function_exists('\\Symfony\\Component\\HttpFoundation\\File\\move_uploaded_file')) {
+            require __DIR__ . '/../../fixes/fix-symfony-file-moving.php';
+        }
+    }
+}

tests/Unit/Listeners/FixSymfonyFileMovingListenerTest.php

@@ -0,0 +1,49 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Spiral\RoadRunnerLaravel\Tests\Unit\Listeners;
+
+use Illuminate\Support\Str;
+use Spiral\RoadRunnerLaravel\Listeners\FixSymfonyFileMovingListener;
+
+/**
+ * @covers \Spiral\RoadRunnerLaravel\Listeners\FixSymfonyFileMovingListener
+ */
+class FixSymfonyFileMovingListenerTest extends AbstractListenerTestCase
+{
+    /**
+     * {@inheritdoc}
+     */
+    public function testHandle(): void
+    {
+        $function_location = '\\Symfony\\Component\\HttpFoundation\\File\\move_uploaded_file';
+
+        $this->assertFalse(\function_exists($function_location));
+        $this->assertFalse(\is_uploaded_file('foo'));
+
+        $this->listenerFactory()->handle(new \stdClass());
+
+        $this->assertTrue(\function_exists($function_location));
+
+        $tmp_dir = $this->createTemporaryDirectory();
+        $old_file_path = $tmp_dir . DIRECTORY_SEPARATOR . Str::random();
+        $new_file_path = $tmp_dir . DIRECTORY_SEPARATOR . Str::random();
+        \file_put_contents($old_file_path, '');
+        $this->assertFileExists($old_file_path);
+        $this->assertTrue($function_location($old_file_path, $new_file_path));
+        $this->assertFileExists($new_file_path);
+        $this->assertFileNotExists($old_file_path);
+        $rnd_file_path1 = $tmp_dir . DIRECTORY_SEPARATOR . Str::random();
+        $rnd_file_path2 = $tmp_dir . DIRECTORY_SEPARATOR . Str::random();
+        $this->assertFalse($function_location($rnd_file_path1, $rnd_file_path2));
+    }
+
+    /**
+     * @return FixSymfonyFileMovingListener
+     */
+    protected function listenerFactory(): FixSymfonyFileMovingListener
+    {
+        return new FixSymfonyFileMovingListener();
+    }
+}