[#111]: fix(edges): wrong vertices edge handling

Author: rustatian

CHANGELOG.md

@@ -92,13 +92,6 @@ func (g *Graph) AddInterfaceDep(vertex *vertex.Vertex, depID string, method Kind
 		return nil
 	}
 
-	for j := 0; j < len(depVertex.Dependencies); j++ {
-		tmpID := depVertex.Dependencies[j].ID
-		if tmpID == vertex.ID {
-			return nil
-		}
-	}
-
 	vertex.NumOfDeps++
 	vertex.Dependencies = append(vertex.Dependencies, depVertex)
 	return nil
@@ -125,14 +118,6 @@ func (g *Graph) AddStructureDep(vertex *vertex.Vertex, depID string, method Kind
 		return nil
 	}
 
-	// append depID vertex
-	for i := 0; i < len(depVertex.Dependencies); i++ {
-		tmpID := depVertex.Dependencies[i].ID
-		if tmpID == vertex.ID {
-			return nil
-		}
-	}
-
 	vertex.NumOfDeps++
 	vertex.Dependencies = append(vertex.Dependencies, depVertex)
 	return nil

pkg/graph/graph.go

@@ -0,0 +1,5 @@
+package p1
+
+type Foo interface {
+	Foo() string
+}

tests/stress/CollectorFuncReturn/CyclicDepsCollectsInit/api/p1/interface.go

@@ -0,0 +1,5 @@
+package p2
+
+type Bar interface {
+	Bar() string
+}

tests/stress/CollectorFuncReturn/CyclicDepsCollectsInit/api/p2/interface.go

@@ -0,0 +1,35 @@
+package p1
+
+import (
+	"github.com/spiral/endure/tests/stress/CyclicDepsCollects/api/p2"
+)
+
+type Plugin1 struct {
+}
+
+func (p1 *Plugin1) Init() error {
+	return nil
+}
+
+func (p1 *Plugin1) Serve() chan error {
+	errCh := make(chan error, 1)
+	return errCh
+}
+
+func (p1 *Plugin1) Stop() error {
+	return nil
+}
+
+func (p1 *Plugin1) Collects() []interface{} {
+	return []interface{}{
+		p1.GetP2,
+	}
+}
+
+func (p1 *Plugin1) Foo() string {
+	return "foo"
+}
+
+func (p1 *Plugin1) GetP2(bar p2.Bar) {
+	_ = bar
+}

tests/stress/CollectorFuncReturn/CyclicDepsCollectsInit/p1/plugin1.go

@@ -0,0 +1,35 @@
+package p2
+
+import (
+	"github.com/spiral/endure/tests/stress/CyclicDepsCollects/api/p1"
+)
+
+type Plugin2 struct {
+}
+
+func (p2 *Plugin2) Init() error {
+	return nil
+}
+
+func (p2 *Plugin2) Serve() chan error {
+	errCh := make(chan error, 1)
+	return errCh
+}
+
+func (p2 *Plugin2) Stop() error {
+	return nil
+}
+
+func (p2 *Plugin2) Collects() []interface{} {
+	return []interface{}{
+		p2.GetP1,
+	}
+}
+
+func (p2 *Plugin2) Bar() string {
+	return "bar"
+}
+
+func (p2 *Plugin2) GetP1(p1 p1.Foo) {
+	_ = p1
+}

tests/stress/CollectorFuncReturn/CyclicDepsCollectsInit/p2/plugin2.go

@@ -0,0 +1,5 @@
+package p1
+
+type Foo interface {
+	Foo() string
+}

tests/stress/CyclicDepsCollects/api/p1/interface.go

@@ -0,0 +1,5 @@
+package p2
+
+type Bar interface {
+	Bar() string
+}

tests/stress/CyclicDepsCollects/api/p2/interface.go

@@ -0,0 +1,35 @@
+package p1
+
+import (
+	"github.com/spiral/endure/tests/stress/CyclicDepsCollects/api/p2"
+)
+
+type Plugin1 struct {
+}
+
+func (p1 *Plugin1) Init() error {
+	return nil
+}
+
+func (p1 *Plugin1) Serve() chan error {
+	errCh := make(chan error, 1)
+	return errCh
+}
+
+func (p1 *Plugin1) Stop() error {
+	return nil
+}
+
+func (p1 *Plugin1) Collects() []interface{} {
+	return []interface{}{
+		p1.GetP2,
+	}
+}
+
+func (p1 *Plugin1) Foo() string {
+	return "foo"
+}
+
+func (p1 *Plugin1) GetP2(bar p2.Bar) {
+	_ = bar
+}

tests/stress/CyclicDepsCollects/p1/plugin1.go

@@ -0,0 +1,35 @@
+package p2
+
+import (
+	"github.com/spiral/endure/tests/stress/CyclicDepsCollects/api/p1"
+)
+
+type Plugin2 struct {
+}
+
+func (p2 *Plugin2) Init() error {
+	return nil
+}
+
+func (p2 *Plugin2) Serve() chan error {
+	errCh := make(chan error, 1)
+	return errCh
+}
+
+func (p2 *Plugin2) Stop() error {
+	return nil
+}
+
+func (p2 *Plugin2) Collects() []interface{} {
+	return []interface{}{
+		p2.GetP1,
+	}
+}
+
+func (p2 *Plugin2) Bar() string {
+	return "bar"
+}
+
+func (p2 *Plugin2) GetP1(p1 p1.Foo) {
+	_ = p1
+}