fix: package comments, error return and deadlock

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>

Author: rustatian

api/interfaces.go

@@ -1,3 +1,4 @@
+// Package api defines public interfaces for the gRPC plugin components.
 package api
 
 import (

codec/codec.go

@@ -1,3 +1,4 @@
+// Package codec provides a raw codec implementation for gRPC that passes through protobuf messages without re-encoding.
 package codec
 
 import (

go.work.sum

@@ -96,6 +96,8 @@ func (h *HealthCheckServer) Watch(_ *grpc_health_v1.HealthCheckRequest, stream g
 
 func (h *HealthCheckServer) SetServingStatus(servingStatus grpc_health_v1.HealthCheckResponse_ServingStatus) {
 	h.mu.Lock()
+	defer h.mu.Unlock()
+
 	if h.shutdown {
 		h.log.Info("health status changing is ignored, because health service is shutdown")
 		return
@@ -112,7 +114,6 @@ func (h *HealthCheckServer) SetServingStatus(servingStatus grpc_health_v1.Health
 		// put the most recent one
 		upd <- servingStatus
 	}
-	h.mu.Unlock()
 }
 
 func (h *HealthCheckServer) Shutdown() {

health_server.go

@@ -1,3 +1,4 @@
+// Package parser provides functionality to parse protobuf files and extract gRPC service definitions.
 package parser
 
 import (
@@ -40,7 +41,10 @@ type Method struct {
 
 // File parses given proto file or returns error.
 func File(file string, importPath string) ([]Service, error) {
-	reader, _ := os.Open(file)
+	reader, err := os.Open(file)
+	if err != nil {
+		return nil, err
+	}
 	defer func() {
 		_ = reader.Close()
 	}()

parser/parse.go

@@ -1,3 +1,4 @@
+// Package grpc implements a gRPC server plugin for RoadRunner that proxies requests to PHP workers.
 package grpc
 
 import (

plugin.go

@@ -20,6 +20,7 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 // SOFTWARE.
 
+// Command protoc-gen-php-grpc is a protoc plugin that generates PHP interfaces for gRPC services.
 package main
 
 import (

protoc_plugins/protoc-gen-php-grpc/main.go

@@ -20,6 +20,7 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 // SOFTWARE.
 
+// Package php provides PHP code generation for gRPC service interfaces.
 package php
 
 import (

protoc_plugins/protoc-gen-php-grpc/php/generate.go

@@ -95,13 +95,11 @@ func body(req *plugin.CodeGeneratorRequest, file *desc.FileDescriptorProto, serv
 			return strings.ReplaceAll(name, "\\\\", "\\")
 		},
 		"resolve_name_const": func(packagePath, serviceName *string) string {
-
 			if defaultOrVal(packagePath) == "" {
 				return defaultOrVal(serviceName)
 			}
 
 			return *packagePath + "." + defaultOrVal(serviceName)
-
 		},
 	}).Parse(phpBody))
 

protoc_plugins/protoc-gen-php-grpc/php/template.go

@@ -1,3 +1,4 @@
+// Package proxy implements a gRPC service proxy that forwards requests to RoadRunner PHP workers.
 package proxy
 
 import (
@@ -192,7 +193,7 @@ func (p *Proxy) invoke(ctx context.Context, method string, in *codec.RawMessage)
 	select {
 	case pl := <-re:
 		if pl.Error() != nil {
-			return nil, err
+			return nil, pl.Error()
 		}
 		// streaming is not supported
 		if pl.Payload().Flags&frame.STREAM != 0 {