Skip to content

Commit 076a9bc

Browse files
committed
signal/mips: Remove FPE_FIXME usage from mips
Ralf Baechle recently merged a change to stop explicitly handling this case on mips, as the case is impossible. Unfortunately when the code in force_fcr31_sig to not use siginfo but a simple interger variable gcc starts warning about an unitialized variable. So add a return statement so gcc knows the code never attempts to use the impossible value. Cc: Ralf Baechle <[email protected]> Signed-off-by: "Eric W. Biederman" <[email protected]>
2 parents 8db6c34 + 2022930 commit 076a9bc

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

arch/mips/include/uapi/asm/siginfo.h

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -123,11 +123,4 @@ typedef struct siginfo {
123123
#define SI_TIMER -3 /* sent by timer expiration */
124124
#define SI_MESGQ -4 /* sent by real time mesq state change */
125125

126-
/*
127-
* SIGFPE si_codes
128-
*/
129-
#ifdef __KERNEL__
130-
#define FPE_FIXME 0 /* Broken dup of SI_USER */
131-
#endif /* __KERNEL__ */
132-
133126
#endif /* _UAPI_ASM_SIGINFO_H */

arch/mips/kernel/traps.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -735,7 +735,7 @@ void force_fcr31_sig(unsigned long fcr31, void __user *fault_addr,
735735
else if (fcr31 & FPU_CSR_INE_X)
736736
si.si_code = FPE_FLTRES;
737737
else
738-
si.si_code = FPE_FIXME;
738+
return; /* Broken hardware? */
739739
force_sig_info(SIGFPE, &si, tsk);
740740
}
741741

0 commit comments

Comments
 (0)