Skip to content

Commit 2d5a710

Browse files
committed
Merge tag 'driver-core-4.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core
Pull driver core fix from Greg KH: "Here is a single patch being reverted to remove a feature that was added in 4.10-rc1 that isn't quite ready for release. It will be redone as a debugfs file instead of a sysfs file in the future" * tag 'driver-core-4.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core: Revert "driver core: Add deferred_probe attribute to devices in sysfs"
2 parents 7f138b9 + c7334ce commit 2d5a710

File tree

4 files changed

+0
-34
lines changed

4 files changed

+0
-34
lines changed

Documentation/ABI/testing/sysfs-devices-deferred_probe

Lines changed: 0 additions & 12 deletions
This file was deleted.

drivers/base/base.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,6 @@ extern void device_unblock_probing(void);
141141
extern struct kset *devices_kset;
142142
extern void devices_kset_move_last(struct device *dev);
143143

144-
extern struct device_attribute dev_attr_deferred_probe;
145-
146144
#if defined(CONFIG_MODULES) && defined(CONFIG_SYSFS)
147145
extern void module_add_driver(struct module *mod, struct device_driver *drv);
148146
extern void module_remove_driver(struct device_driver *drv);

drivers/base/core.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1060,14 +1060,8 @@ static int device_add_attrs(struct device *dev)
10601060
goto err_remove_dev_groups;
10611061
}
10621062

1063-
error = device_create_file(dev, &dev_attr_deferred_probe);
1064-
if (error)
1065-
goto err_remove_online;
1066-
10671063
return 0;
10681064

1069-
err_remove_online:
1070-
device_remove_file(dev, &dev_attr_online);
10711065
err_remove_dev_groups:
10721066
device_remove_groups(dev, dev->groups);
10731067
err_remove_type_groups:
@@ -1085,7 +1079,6 @@ static void device_remove_attrs(struct device *dev)
10851079
struct class *class = dev->class;
10861080
const struct device_type *type = dev->type;
10871081

1088-
device_remove_file(dev, &dev_attr_deferred_probe);
10891082
device_remove_file(dev, &dev_attr_online);
10901083
device_remove_groups(dev, dev->groups);
10911084

drivers/base/dd.c

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -53,19 +53,6 @@ static LIST_HEAD(deferred_probe_pending_list);
5353
static LIST_HEAD(deferred_probe_active_list);
5454
static atomic_t deferred_trigger_count = ATOMIC_INIT(0);
5555

56-
static ssize_t deferred_probe_show(struct device *dev,
57-
struct device_attribute *attr, char *buf)
58-
{
59-
bool value;
60-
61-
mutex_lock(&deferred_probe_mutex);
62-
value = !list_empty(&dev->p->deferred_probe);
63-
mutex_unlock(&deferred_probe_mutex);
64-
65-
return sprintf(buf, "%d\n", value);
66-
}
67-
DEVICE_ATTR_RO(deferred_probe);
68-
6956
/*
7057
* In some cases, like suspend to RAM or hibernation, It might be reasonable
7158
* to prohibit probing of devices as it could be unsafe.

0 commit comments

Comments
 (0)