nvme: fabrics commands should use the fctype field for data direction

Jon Derrick · Christoph Hellwig · commit 2fd4167fadd1 · 2017-07-25T17:58:32.000+02:00
Fabrics commands with opcode 0x7F use the fctype field to indicate data direction. Signed-off-by: Jon Derrick <jonathan.derrick@intel.com> Reviewed-by: Sagi Grimberg <sai@grmberg.me> Signed-off-by: Christoph Hellwig <hch@lst.de> Fixes: eb793e2 ("nvme.h: add NVMe over Fabrics definitions")
diff --git a/include/linux/nvme.h b/include/linux/nvme.h
@@ -1006,7 +1006,7 @@ static inline bool nvme_is_write(struct nvme_command *cmd)
 	 * Why can't we simply have a Fabrics In and Fabrics out command?
 	 */
 	if (unlikely(cmd->common.opcode == nvme_fabrics_command))
-		return cmd->fabrics.opcode & 1;
+		return cmd->fabrics.fctype & 1;
 	return cmd->common.opcode & 1;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1006,7 +1006,7 @@ static inline bool nvme_is_write(struct nvme_command *cmd)`
`1006`	`1006`	`* Why can't we simply have a Fabrics In and Fabrics out command?`
`1007`	`1007`	`*/`
`1008`	`1008`	`if (unlikely(cmd->common.opcode == nvme_fabrics_command))`
`1009`		`- return cmd->fabrics.opcode & 1;`
	`1009`	`+ return cmd->fabrics.fctype & 1;`
`1010`	`1010`	`return cmd->common.opcode & 1;`
`1011`	`1011`	`}`
`1012`	`1012`