arm64: atomics: Remove '&' from '+&' asm constraint in lse atomics

wildea01 · wildea01 · commit 32fb5d73c98b · 2017-07-20T10:20:54.000+01:00
The lse implementation of atomic64_dec_if_positive uses the '+&amp;' constraint,
but the '&amp;' is redundant and confusing in this case, since early clobber
on a read/write operand is a strange concept.

Replace the constraint with '+'.

Signed-off-by: Will Deacon &lt;will.deacon@arm.com&gt;
diff --git a/arch/arm64/include/asm/atomic_lse.h b/arch/arm64/include/asm/atomic_lse.h
@@ -435,7 +435,7 @@ static inline long atomic64_dec_if_positive(atomic64_t *v)
 	"	sub	x30, x30, %[ret]\n"
 	"	cbnz	x30, 1b\n"
 	"2:")
-	: [ret] "+&r" (x0), [v] "+Q" (v->counter)
+	: [ret] "+r" (x0), [v] "+Q" (v->counter)
 	:
 	: __LL_SC_CLOBBERS, "cc", "memory");
 

Original file line number	Diff line number	Diff line change
`@@ -435,7 +435,7 @@ static inline long atomic64_dec_if_positive(atomic64_t *v)`
`435`	`435`	`" sub x30, x30, %[ret]\n"`
`436`	`436`	`" cbnz x30, 1b\n"`
`437`	`437`	`"2:")`
`438`		`- : [ret] "+&r" (x0), [v] "+Q" (v->counter)`
	`438`	`+ : [ret] "+r" (x0), [v] "+Q" (v->counter)`
`439`	`439`	`:`
`440`	`440`	`: __LL_SC_CLOBBERS, "cc", "memory");`
`441`	`441`