Skip to content

Commit 4a704d6

Browse files
committed
Merge tag 'kbuild-fixes-v4.14' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
Pull Kbuild fixes from Masahiro Yamada: "Here are some early Kbuild fixes. The in-kernel firmware was removed during the previous merge window. Since then, some bug reports of broken rpm building are flying in ML. We need to fix it now. Summary: - remove firmware install from rpm-pkg / deb-pkg - fix mismatch between release number and UTS_VERSION for rpm-pkg" * tag 'kbuild-fixes-v4.14' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild: kbuild: rpm-pkg: fix version number handling kbuild: deb-pkg: remove firmware package support kbuild: rpm-pkg: delete firmware_install to fix build error
2 parents 449cd5d + 25b080b commit 4a704d6

File tree

4 files changed

+5
-42
lines changed

4 files changed

+5
-42
lines changed

scripts/mkversion

Lines changed: 0 additions & 6 deletions
This file was deleted.

scripts/package/Makefile

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,6 @@ rpm-pkg rpm: FORCE
5050
$(MAKE) clean
5151
$(CONFIG_SHELL) $(MKSPEC) >$(objtree)/kernel.spec
5252
$(call cmd,src_tar,$(KERNELPATH),kernel.spec)
53-
$(CONFIG_SHELL) $(srctree)/scripts/mkversion > $(objtree)/.tmp_version
54-
mv -f $(objtree)/.tmp_version $(objtree)/.version
5553
rpmbuild $(RPMOPTS) --target $(UTS_MACHINE) -ta $(KERNELPATH).tar.gz
5654
rm $(KERNELPATH).tar.gz kernel.spec
5755

@@ -60,9 +58,6 @@ rpm-pkg rpm: FORCE
6058
binrpm-pkg: FORCE
6159
$(MAKE) KBUILD_SRC=
6260
$(CONFIG_SHELL) $(MKSPEC) prebuilt > $(objtree)/binkernel.spec
63-
$(CONFIG_SHELL) $(srctree)/scripts/mkversion > $(objtree)/.tmp_version
64-
mv -f $(objtree)/.tmp_version $(objtree)/.version
65-
6661
rpmbuild $(RPMOPTS) --define "_builddir $(objtree)" --target \
6762
$(UTS_MACHINE) -bb $(objtree)/binkernel.spec
6863
rm binkernel.spec

scripts/package/builddeb

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -92,12 +92,10 @@ else
9292
fi
9393
sourcename=$KDEB_SOURCENAME
9494
tmpdir="$objtree/debian/tmp"
95-
fwdir="$objtree/debian/fwtmp"
9695
kernel_headers_dir="$objtree/debian/hdrtmp"
9796
libc_headers_dir="$objtree/debian/headertmp"
9897
dbg_dir="$objtree/debian/dbgtmp"
9998
packagename=linux-image-$version
100-
fwpackagename=linux-firmware-image-$version
10199
kernel_headers_packagename=linux-headers-$version
102100
libc_headers_packagename=linux-libc-dev
103101
dbg_packagename=$packagename-dbg
@@ -126,10 +124,9 @@ esac
126124
BUILD_DEBUG="$(grep -s '^CONFIG_DEBUG_INFO=y' $KCONFIG_CONFIG || true)"
127125

128126
# Setup the directory structure
129-
rm -rf "$tmpdir" "$fwdir" "$kernel_headers_dir" "$libc_headers_dir" "$dbg_dir" $objtree/debian/files
127+
rm -rf "$tmpdir" "$kernel_headers_dir" "$libc_headers_dir" "$dbg_dir" $objtree/debian/files
130128
mkdir -m 755 -p "$tmpdir/DEBIAN"
131129
mkdir -p "$tmpdir/lib" "$tmpdir/boot"
132-
mkdir -p "$fwdir/lib/firmware/$version/"
133130
mkdir -p "$kernel_headers_dir/lib/modules/$version/"
134131

135132
# Build and install the kernel
@@ -306,7 +303,6 @@ else
306303
cat <<EOF >> debian/control
307304
308305
Package: $packagename
309-
Suggests: $fwpackagename
310306
Architecture: any
311307
Description: Linux kernel, version $version
312308
This package contains the Linux kernel, modules and corresponding other
@@ -345,22 +341,6 @@ Description: Linux kernel headers for $KERNELRELEASE on \${kernel:debarch}
345341
This is useful for people who need to build external modules
346342
EOF
347343

348-
# Do we have firmware? Move it out of the way and build it into a package.
349-
if [ -e "$tmpdir/lib/firmware" ]; then
350-
mv "$tmpdir/lib/firmware"/* "$fwdir/lib/firmware/$version/"
351-
rmdir "$tmpdir/lib/firmware"
352-
353-
cat <<EOF >> debian/control
354-
355-
Package: $fwpackagename
356-
Architecture: all
357-
Description: Linux kernel firmware, version $version
358-
This package contains firmware from the Linux kernel, version $version.
359-
EOF
360-
361-
create_package "$fwpackagename" "$fwdir"
362-
fi
363-
364344
cat <<EOF >> debian/control
365345
366346
Package: $libc_headers_packagename

scripts/package/mkspec

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,7 @@ __KERNELRELEASE=`echo $KERNELRELEASE | sed -e "s/-/_/g"`
2727
echo "Name: kernel"
2828
echo "Summary: The Linux Kernel"
2929
echo "Version: $__KERNELRELEASE"
30-
# we need to determine the NEXT version number so that uname and
31-
# rpm -q will agree
32-
echo "Release: `. $srctree/scripts/mkversion`"
30+
echo "Release: $(cat .version 2>/dev/null || echo 1)"
3331
echo "License: GPL"
3432
echo "Group: System Environment/Kernel"
3533
echo "Vendor: The Linux Community"
@@ -77,7 +75,7 @@ fi
7775
echo "%build"
7876

7977
if ! $PREBUILT; then
80-
echo "make clean && make %{?_smp_mflags}"
78+
echo "make clean && make %{?_smp_mflags} KBUILD_BUILD_VERSION=%{release}"
8179
echo ""
8280
fi
8381

@@ -88,11 +86,8 @@ echo 'mkdir -p $RPM_BUILD_ROOT/boot/efi $RPM_BUILD_ROOT/lib/modules'
8886
echo "%else"
8987
echo 'mkdir -p $RPM_BUILD_ROOT/boot $RPM_BUILD_ROOT/lib/modules'
9088
echo "%endif"
91-
echo 'mkdir -p $RPM_BUILD_ROOT'"/lib/firmware/$KERNELRELEASE"
9289

93-
echo 'INSTALL_MOD_PATH=$RPM_BUILD_ROOT make %{?_smp_mflags} KBUILD_SRC= mod-fw= modules_install'
94-
echo 'INSTALL_FW_PATH=$RPM_BUILD_ROOT'"/lib/firmware/$KERNELRELEASE"
95-
echo 'make INSTALL_FW_PATH=$INSTALL_FW_PATH' firmware_install
90+
echo 'INSTALL_MOD_PATH=$RPM_BUILD_ROOT make %{?_smp_mflags} KBUILD_SRC= modules_install'
9691
echo "%ifarch ia64"
9792
echo 'cp $KBUILD_IMAGE $RPM_BUILD_ROOT'"/boot/efi/vmlinuz-$KERNELRELEASE"
9893
echo 'ln -s '"efi/vmlinuz-$KERNELRELEASE" '$RPM_BUILD_ROOT'"/boot/"
@@ -119,7 +114,7 @@ if ! $PREBUILT; then
119114
echo 'rm -f $RPM_BUILD_ROOT'"/lib/modules/$KERNELRELEASE/build"
120115
echo 'rm -f $RPM_BUILD_ROOT'"/lib/modules/$KERNELRELEASE/source"
121116
echo "mkdir -p "'$RPM_BUILD_ROOT'"/usr/src/kernels/$KERNELRELEASE"
122-
echo "EXCLUDES=\"$RCS_TAR_IGNORE --exclude .tmp_versions --exclude=*vmlinux* --exclude=*.o --exclude=*.ko --exclude=*.cmd --exclude=Documentation --exclude=firmware --exclude .config.old --exclude .missing-syscalls.d\""
117+
echo "EXCLUDES=\"$RCS_TAR_IGNORE --exclude .tmp_versions --exclude=*vmlinux* --exclude=*.o --exclude=*.ko --exclude=*.cmd --exclude=Documentation --exclude .config.old --exclude .missing-syscalls.d\""
123118
echo "tar "'$EXCLUDES'" -cf- . | (cd "'$RPM_BUILD_ROOT'"/usr/src/kernels/$KERNELRELEASE;tar xvf -)"
124119
echo 'cd $RPM_BUILD_ROOT'"/lib/modules/$KERNELRELEASE"
125120
echo "ln -sf /usr/src/kernels/$KERNELRELEASE build"
@@ -154,7 +149,6 @@ echo '%defattr (-, root, root)'
154149
echo "/lib/modules/$KERNELRELEASE"
155150
echo "%exclude /lib/modules/$KERNELRELEASE/build"
156151
echo "%exclude /lib/modules/$KERNELRELEASE/source"
157-
echo "/lib/firmware/$KERNELRELEASE"
158152
echo "/boot/*"
159153
echo ""
160154
echo "%files headers"

0 commit comments

Comments
 (0)