Skip to content

Commit 4ab6cf1

Browse files
QSchulzbebarino
authored andcommitted
ASoC: atmel-classd: remove aclk clock
Since gclk (generated-clk) is now able to determine the rate of the audio_pll, there is no need for classd to have a direct phandle to the audio_pll while already having a phandle to gclk. Thus, remove all mentions to aclk in classd driver and update macros and variable names. Signed-off-by: Quentin Schulz <[email protected]> Acked-by: Mark Brown <[email protected]> Acked-by: Nicolas Ferre <[email protected]> Signed-off-by: Stephen Boyd <[email protected]>
1 parent f8fef41 commit 4ab6cf1

File tree

1 file changed

+14
-33
lines changed

1 file changed

+14
-33
lines changed

sound/soc/atmel/atmel-classd.c

Lines changed: 14 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ struct atmel_classd {
3232
struct regmap *regmap;
3333
struct clk *pclk;
3434
struct clk *gclk;
35-
struct clk *aclk;
3635
int irq;
3736
const struct atmel_classd_pdata *pdata;
3837
};
@@ -330,11 +329,6 @@ static int atmel_classd_codec_dai_startup(struct snd_pcm_substream *substream,
330329
{
331330
struct snd_soc_pcm_runtime *rtd = substream->private_data;
332331
struct atmel_classd *dd = snd_soc_card_get_drvdata(rtd->card);
333-
int ret;
334-
335-
ret = clk_prepare_enable(dd->aclk);
336-
if (ret)
337-
return ret;
338332

339333
return clk_prepare_enable(dd->gclk);
340334
}
@@ -357,31 +351,31 @@ static int atmel_classd_codec_dai_digital_mute(struct snd_soc_dai *codec_dai,
357351
return 0;
358352
}
359353

360-
#define CLASSD_ACLK_RATE_11M2896_MPY_8 (112896 * 100 * 8)
361-
#define CLASSD_ACLK_RATE_12M288_MPY_8 (12288 * 1000 * 8)
354+
#define CLASSD_GCLK_RATE_11M2896_MPY_8 (112896 * 100 * 8)
355+
#define CLASSD_GCLK_RATE_12M288_MPY_8 (12288 * 1000 * 8)
362356

363357
static struct {
364358
int rate;
365359
int sample_rate;
366360
int dsp_clk;
367-
unsigned long aclk_rate;
361+
unsigned long gclk_rate;
368362
} const sample_rates[] = {
369363
{ 8000, CLASSD_INTPMR_FRAME_8K,
370-
CLASSD_INTPMR_DSP_CLK_FREQ_12M288, CLASSD_ACLK_RATE_12M288_MPY_8 },
364+
CLASSD_INTPMR_DSP_CLK_FREQ_12M288, CLASSD_GCLK_RATE_12M288_MPY_8 },
371365
{ 16000, CLASSD_INTPMR_FRAME_16K,
372-
CLASSD_INTPMR_DSP_CLK_FREQ_12M288, CLASSD_ACLK_RATE_12M288_MPY_8 },
366+
CLASSD_INTPMR_DSP_CLK_FREQ_12M288, CLASSD_GCLK_RATE_12M288_MPY_8 },
373367
{ 32000, CLASSD_INTPMR_FRAME_32K,
374-
CLASSD_INTPMR_DSP_CLK_FREQ_12M288, CLASSD_ACLK_RATE_12M288_MPY_8 },
368+
CLASSD_INTPMR_DSP_CLK_FREQ_12M288, CLASSD_GCLK_RATE_12M288_MPY_8 },
375369
{ 48000, CLASSD_INTPMR_FRAME_48K,
376-
CLASSD_INTPMR_DSP_CLK_FREQ_12M288, CLASSD_ACLK_RATE_12M288_MPY_8 },
370+
CLASSD_INTPMR_DSP_CLK_FREQ_12M288, CLASSD_GCLK_RATE_12M288_MPY_8 },
377371
{ 96000, CLASSD_INTPMR_FRAME_96K,
378-
CLASSD_INTPMR_DSP_CLK_FREQ_12M288, CLASSD_ACLK_RATE_12M288_MPY_8 },
372+
CLASSD_INTPMR_DSP_CLK_FREQ_12M288, CLASSD_GCLK_RATE_12M288_MPY_8 },
379373
{ 22050, CLASSD_INTPMR_FRAME_22K,
380-
CLASSD_INTPMR_DSP_CLK_FREQ_11M2896, CLASSD_ACLK_RATE_11M2896_MPY_8 },
374+
CLASSD_INTPMR_DSP_CLK_FREQ_11M2896, CLASSD_GCLK_RATE_11M2896_MPY_8 },
381375
{ 44100, CLASSD_INTPMR_FRAME_44K,
382-
CLASSD_INTPMR_DSP_CLK_FREQ_11M2896, CLASSD_ACLK_RATE_11M2896_MPY_8 },
376+
CLASSD_INTPMR_DSP_CLK_FREQ_11M2896, CLASSD_GCLK_RATE_11M2896_MPY_8 },
383377
{ 88200, CLASSD_INTPMR_FRAME_88K,
384-
CLASSD_INTPMR_DSP_CLK_FREQ_11M2896, CLASSD_ACLK_RATE_11M2896_MPY_8 },
378+
CLASSD_INTPMR_DSP_CLK_FREQ_11M2896, CLASSD_GCLK_RATE_11M2896_MPY_8 },
385379
};
386380

387381
static int
@@ -410,13 +404,12 @@ atmel_classd_codec_dai_hw_params(struct snd_pcm_substream *substream,
410404
}
411405

412406
dev_dbg(codec->dev,
413-
"Selected SAMPLE_RATE of %dHz, ACLK_RATE of %ldHz\n",
414-
sample_rates[best].rate, sample_rates[best].aclk_rate);
407+
"Selected SAMPLE_RATE of %dHz, GCLK_RATE of %ldHz\n",
408+
sample_rates[best].rate, sample_rates[best].gclk_rate);
415409

416410
clk_disable_unprepare(dd->gclk);
417-
clk_disable_unprepare(dd->aclk);
418411

419-
ret = clk_set_rate(dd->aclk, sample_rates[best].aclk_rate);
412+
ret = clk_set_rate(dd->gclk, sample_rates[best].gclk_rate);
420413
if (ret)
421414
return ret;
422415

@@ -426,10 +419,6 @@ atmel_classd_codec_dai_hw_params(struct snd_pcm_substream *substream,
426419

427420
snd_soc_update_bits(codec, CLASSD_INTPMR, mask, val);
428421

429-
ret = clk_prepare_enable(dd->aclk);
430-
if (ret)
431-
return ret;
432-
433422
return clk_prepare_enable(dd->gclk);
434423
}
435424

@@ -441,7 +430,6 @@ atmel_classd_codec_dai_shutdown(struct snd_pcm_substream *substream,
441430
struct atmel_classd *dd = snd_soc_card_get_drvdata(rtd->card);
442431

443432
clk_disable_unprepare(dd->gclk);
444-
clk_disable_unprepare(dd->aclk);
445433
}
446434

447435
static int atmel_classd_codec_dai_prepare(struct snd_pcm_substream *substream,
@@ -596,13 +584,6 @@ static int atmel_classd_probe(struct platform_device *pdev)
596584
return ret;
597585
}
598586

599-
dd->aclk = devm_clk_get(dev, "aclk");
600-
if (IS_ERR(dd->aclk)) {
601-
ret = PTR_ERR(dd->aclk);
602-
dev_err(dev, "failed to get audio clock: %d\n", ret);
603-
return ret;
604-
}
605-
606587
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
607588
io_base = devm_ioremap_resource(dev, res);
608589
if (IS_ERR(io_base)) {

0 commit comments

Comments
 (0)