Skip to content

Commit 60c4081

Browse files
atenartherbertx
authored andcommitted
crypto: inside-secure - fix the sha state length in hmac_sha1_setkey
A check is performed on the ipad/opad in the safexcel_hmac_sha1_setkey function, but the index used by the loop doing it is wrong. It is currently the size of the state array while it should be the size of a sha1 state. This patch fixes it. Fixes: 1b44c5a ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver") Reported-by: Dan Carpenter <[email protected]> Signed-off-by: Antoine Tenart <[email protected]> Signed-off-by: Herbert Xu <[email protected]>
1 parent 42ef3be commit 60c4081

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/crypto/inside-secure/safexcel_hash.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -883,7 +883,7 @@ static int safexcel_hmac_sha1_setkey(struct crypto_ahash *tfm, const u8 *key,
883883
if (ret)
884884
return ret;
885885

886-
for (i = 0; i < ARRAY_SIZE(istate.state); i++) {
886+
for (i = 0; i < SHA1_DIGEST_SIZE / sizeof(u32); i++) {
887887
if (ctx->ipad[i] != le32_to_cpu(istate.state[i]) ||
888888
ctx->opad[i] != le32_to_cpu(ostate.state[i])) {
889889
ctx->base.needs_inv = true;

0 commit comments

Comments
 (0)