Skip to content

Commit 680352b

Browse files
committed
Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
Pull x86 fixes from Ingo Molnar: "Two fixes: dead code removal, plus a SME memory encryption fix on 32-bit kernels that crashed Xen guests" * 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: x86/cpu: Remove unused and undefined __generic_processor_info() declaration x86/mm: Make the SME mask a u64
2 parents 040b9d7 + e2329b4 commit 680352b

File tree

5 files changed

+13
-9
lines changed

5 files changed

+13
-9
lines changed

arch/x86/include/asm/mem_encrypt.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
#ifdef CONFIG_AMD_MEM_ENCRYPT
2323

24-
extern unsigned long sme_me_mask;
24+
extern u64 sme_me_mask;
2525

2626
void sme_encrypt_execute(unsigned long encrypted_kernel_vaddr,
2727
unsigned long decrypted_kernel_vaddr,
@@ -49,7 +49,7 @@ void swiotlb_set_mem_attributes(void *vaddr, unsigned long size);
4949

5050
#else /* !CONFIG_AMD_MEM_ENCRYPT */
5151

52-
#define sme_me_mask 0UL
52+
#define sme_me_mask 0ULL
5353

5454
static inline void __init sme_early_encrypt(resource_size_t paddr,
5555
unsigned long size) { }

arch/x86/include/asm/mpspec.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ static inline void e820__memblock_alloc_reserved_mpc_new(void) { }
8686
#endif
8787

8888
int generic_processor_info(int apicid, int version);
89-
int __generic_processor_info(int apicid, int version, bool enabled);
9089

9190
#define PHYSID_ARRAY_SIZE BITS_TO_LONGS(MAX_LOCAL_APIC)
9291

arch/x86/kernel/apic/apic.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2130,7 +2130,7 @@ int generic_processor_info(int apicid, int version)
21302130
* Since fixing handling of boot_cpu_physical_apicid requires
21312131
* another discussion and tests on each platform, we leave it
21322132
* for now and here we use read_apic_id() directly in this
2133-
* function, __generic_processor_info().
2133+
* function, generic_processor_info().
21342134
*/
21352135
if (disabled_cpu_apicid != BAD_APICID &&
21362136
disabled_cpu_apicid != read_apic_id() &&

arch/x86/mm/mem_encrypt.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ static char sme_cmdline_off[] __initdata = "off";
3737
* reside in the .data section so as not to be zeroed out when the .bss
3838
* section is later cleared.
3939
*/
40-
unsigned long sme_me_mask __section(.data) = 0;
40+
u64 sme_me_mask __section(.data) = 0;
4141
EXPORT_SYMBOL_GPL(sme_me_mask);
4242

4343
/* Buffer used for early in-place encryption by BSP, no locking needed */

include/linux/mem_encrypt.h

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
#else /* !CONFIG_ARCH_HAS_MEM_ENCRYPT */
2323

24-
#define sme_me_mask 0UL
24+
#define sme_me_mask 0ULL
2525

2626
#endif /* CONFIG_ARCH_HAS_MEM_ENCRYPT */
2727

@@ -30,18 +30,23 @@ static inline bool sme_active(void)
3030
return !!sme_me_mask;
3131
}
3232

33-
static inline unsigned long sme_get_me_mask(void)
33+
static inline u64 sme_get_me_mask(void)
3434
{
3535
return sme_me_mask;
3636
}
3737

38+
#ifdef CONFIG_AMD_MEM_ENCRYPT
3839
/*
3940
* The __sme_set() and __sme_clr() macros are useful for adding or removing
4041
* the encryption mask from a value (e.g. when dealing with pagetable
4142
* entries).
4243
*/
43-
#define __sme_set(x) ((unsigned long)(x) | sme_me_mask)
44-
#define __sme_clr(x) ((unsigned long)(x) & ~sme_me_mask)
44+
#define __sme_set(x) ((x) | sme_me_mask)
45+
#define __sme_clr(x) ((x) & ~sme_me_mask)
46+
#else
47+
#define __sme_set(x) (x)
48+
#define __sme_clr(x) (x)
49+
#endif
4550

4651
#endif /* __ASSEMBLY__ */
4752

0 commit comments

Comments
 (0)