Skip to content

Commit 7b4af79

Browse files
charleskeepaxbroonie
authored andcommitted
ASoC: wm_adsp: Acknowledge controls should also check the DSP is running
We should not be writing acknowledge controls until the firmware is running, as in the case of preloaded firmwares the DSP memory may be unaccessible to whilst in the preloaded state. This means a write to the control during this time could be lost. Signed-off-by: Charles Keepax <[email protected]> Signed-off-by: Mark Brown <[email protected]>
1 parent 67430a3 commit 7b4af79

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sound/soc/codecs/wm_adsp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -952,7 +952,7 @@ static int wm_coeff_put_acked(struct snd_kcontrol *kctl,
952952

953953
mutex_lock(&ctl->dsp->pwr_lock);
954954

955-
if (ctl->enabled)
955+
if (ctl->enabled && ctl->dsp->running)
956956
ret = wm_coeff_write_acked_control(ctl, val);
957957
else
958958
ret = -EPERM;

0 commit comments

Comments
 (0)