Skip to content

Commit a5fef53

Browse files
boddobrobclark
authored andcommitted
drm/msm/dsi: Fix bug in dsi_mgr_phy_enable
A recent commit introduces a bug in dsi_mgr_phy_enable. In the non dual DSI mode, we reset the mdsi (master DSI) PHY. This isn't right since master and slave DSI exist only in dual DSI mode. For the normal mode of operation, we should simply reset the PHY of the DSI device (i.e. msm_dsi) corresponding to the current bridge. Usage of the wrong DSI pointer also resulted in a static checker warning. That too is resolved with this fix. Fixes: b62aa70 (drm/msm/dsi: Move PHY operations out of host) Reported-by: Dan Carpenter <[email protected]> Signed-off-by: Archit Taneja <[email protected]> Reviewed-by: Rob Clark <[email protected]> Signed-off-by: Rob Clark <[email protected]>
1 parent 1a5dff5 commit a5fef53

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/msm/dsi/dsi_manager.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ dsi_mgr_phy_enable(int id,
171171
}
172172
}
173173
} else {
174-
msm_dsi_host_reset_phy(mdsi->host);
174+
msm_dsi_host_reset_phy(msm_dsi->host);
175175
ret = enable_phy(msm_dsi, src_pll_id, &shared_timings[id]);
176176
if (ret)
177177
return ret;

0 commit comments

Comments
 (0)