Skip to content

Commit c002075

Browse files
andy-shevChristoph Hellwig
authored andcommitted
efi: switch to use new generic UUID API
There are new types and helpers that are supposed to be used in new code. As a preparation to get rid of legacy types and API functions do the conversion here. Signed-off-by: Andy Shevchenko <[email protected]> Acked-by: Ard Biesheuvel <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
1 parent 14ccee7 commit c002075

File tree

3 files changed

+54
-54
lines changed

3 files changed

+54
-54
lines changed

drivers/firmware/efi/cper.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -534,7 +534,7 @@ static void
534534
cper_estatus_print_section(const char *pfx, struct acpi_hest_generic_data *gdata,
535535
int sec_no)
536536
{
537-
uuid_le *sec_type = (uuid_le *)gdata->section_type;
537+
guid_t *sec_type = (guid_t *)gdata->section_type;
538538
__u16 severity;
539539
char newpfx[64];
540540

@@ -545,20 +545,20 @@ cper_estatus_print_section(const char *pfx, struct acpi_hest_generic_data *gdata
545545
printk("%s""Error %d, type: %s\n", pfx, sec_no,
546546
cper_severity_str(severity));
547547
if (gdata->validation_bits & CPER_SEC_VALID_FRU_ID)
548-
printk("%s""fru_id: %pUl\n", pfx, (uuid_le *)gdata->fru_id);
548+
printk("%s""fru_id: %pUl\n", pfx, gdata->fru_id);
549549
if (gdata->validation_bits & CPER_SEC_VALID_FRU_TEXT)
550550
printk("%s""fru_text: %.20s\n", pfx, gdata->fru_text);
551551

552552
snprintf(newpfx, sizeof(newpfx), "%s%s", pfx, INDENT_SP);
553-
if (!uuid_le_cmp(*sec_type, CPER_SEC_PROC_GENERIC)) {
553+
if (guid_equal(sec_type, &CPER_SEC_PROC_GENERIC)) {
554554
struct cper_sec_proc_generic *proc_err = acpi_hest_get_payload(gdata);
555555

556556
printk("%s""section_type: general processor error\n", newpfx);
557557
if (gdata->error_data_length >= sizeof(*proc_err))
558558
cper_print_proc_generic(newpfx, proc_err);
559559
else
560560
goto err_section_too_small;
561-
} else if (!uuid_le_cmp(*sec_type, CPER_SEC_PLATFORM_MEM)) {
561+
} else if (guid_equal(sec_type, &CPER_SEC_PLATFORM_MEM)) {
562562
struct cper_sec_mem_err *mem_err = acpi_hest_get_payload(gdata);
563563

564564
printk("%s""section_type: memory error\n", newpfx);
@@ -568,7 +568,7 @@ cper_estatus_print_section(const char *pfx, struct acpi_hest_generic_data *gdata
568568
gdata->error_data_length);
569569
else
570570
goto err_section_too_small;
571-
} else if (!uuid_le_cmp(*sec_type, CPER_SEC_PCIE)) {
571+
} else if (guid_equal(sec_type, &CPER_SEC_PCIE)) {
572572
struct cper_sec_pcie *pcie = acpi_hest_get_payload(gdata);
573573

574574
printk("%s""section_type: PCIe error\n", newpfx);

include/linux/cper.h

Lines changed: 47 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -74,36 +74,36 @@ enum {
7474
* Corrected Machine Check
7575
*/
7676
#define CPER_NOTIFY_CMC \
77-
UUID_LE(0x2DCE8BB1, 0xBDD7, 0x450e, 0xB9, 0xAD, 0x9C, 0xF4, \
78-
0xEB, 0xD4, 0xF8, 0x90)
77+
GUID_INIT(0x2DCE8BB1, 0xBDD7, 0x450e, 0xB9, 0xAD, 0x9C, 0xF4, \
78+
0xEB, 0xD4, 0xF8, 0x90)
7979
/* Corrected Platform Error */
8080
#define CPER_NOTIFY_CPE \
81-
UUID_LE(0x4E292F96, 0xD843, 0x4a55, 0xA8, 0xC2, 0xD4, 0x81, \
82-
0xF2, 0x7E, 0xBE, 0xEE)
81+
GUID_INIT(0x4E292F96, 0xD843, 0x4a55, 0xA8, 0xC2, 0xD4, 0x81, \
82+
0xF2, 0x7E, 0xBE, 0xEE)
8383
/* Machine Check Exception */
8484
#define CPER_NOTIFY_MCE \
85-
UUID_LE(0xE8F56FFE, 0x919C, 0x4cc5, 0xBA, 0x88, 0x65, 0xAB, \
86-
0xE1, 0x49, 0x13, 0xBB)
85+
GUID_INIT(0xE8F56FFE, 0x919C, 0x4cc5, 0xBA, 0x88, 0x65, 0xAB, \
86+
0xE1, 0x49, 0x13, 0xBB)
8787
/* PCI Express Error */
8888
#define CPER_NOTIFY_PCIE \
89-
UUID_LE(0xCF93C01F, 0x1A16, 0x4dfc, 0xB8, 0xBC, 0x9C, 0x4D, \
90-
0xAF, 0x67, 0xC1, 0x04)
89+
GUID_INIT(0xCF93C01F, 0x1A16, 0x4dfc, 0xB8, 0xBC, 0x9C, 0x4D, \
90+
0xAF, 0x67, 0xC1, 0x04)
9191
/* INIT Record (for IPF) */
9292
#define CPER_NOTIFY_INIT \
93-
UUID_LE(0xCC5263E8, 0x9308, 0x454a, 0x89, 0xD0, 0x34, 0x0B, \
94-
0xD3, 0x9B, 0xC9, 0x8E)
93+
GUID_INIT(0xCC5263E8, 0x9308, 0x454a, 0x89, 0xD0, 0x34, 0x0B, \
94+
0xD3, 0x9B, 0xC9, 0x8E)
9595
/* Non-Maskable Interrupt */
9696
#define CPER_NOTIFY_NMI \
97-
UUID_LE(0x5BAD89FF, 0xB7E6, 0x42c9, 0x81, 0x4A, 0xCF, 0x24, \
98-
0x85, 0xD6, 0xE9, 0x8A)
97+
GUID_INIT(0x5BAD89FF, 0xB7E6, 0x42c9, 0x81, 0x4A, 0xCF, 0x24, \
98+
0x85, 0xD6, 0xE9, 0x8A)
9999
/* BOOT Error Record */
100100
#define CPER_NOTIFY_BOOT \
101-
UUID_LE(0x3D61A466, 0xAB40, 0x409a, 0xA6, 0x98, 0xF3, 0x62, \
102-
0xD4, 0x64, 0xB3, 0x8F)
101+
GUID_INIT(0x3D61A466, 0xAB40, 0x409a, 0xA6, 0x98, 0xF3, 0x62, \
102+
0xD4, 0x64, 0xB3, 0x8F)
103103
/* DMA Remapping Error */
104104
#define CPER_NOTIFY_DMAR \
105-
UUID_LE(0x667DD791, 0xC6B3, 0x4c27, 0x8A, 0x6B, 0x0F, 0x8E, \
106-
0x72, 0x2D, 0xEB, 0x41)
105+
GUID_INIT(0x667DD791, 0xC6B3, 0x4c27, 0x8A, 0x6B, 0x0F, 0x8E, \
106+
0x72, 0x2D, 0xEB, 0x41)
107107

108108
/*
109109
* Flags bits definitions for flags in struct cper_record_header
@@ -170,50 +170,50 @@ enum {
170170
* Processor Generic
171171
*/
172172
#define CPER_SEC_PROC_GENERIC \
173-
UUID_LE(0x9876CCAD, 0x47B4, 0x4bdb, 0xB6, 0x5E, 0x16, 0xF1, \
174-
0x93, 0xC4, 0xF3, 0xDB)
173+
GUID_INIT(0x9876CCAD, 0x47B4, 0x4bdb, 0xB6, 0x5E, 0x16, 0xF1, \
174+
0x93, 0xC4, 0xF3, 0xDB)
175175
/* Processor Specific: X86/X86_64 */
176176
#define CPER_SEC_PROC_IA \
177-
UUID_LE(0xDC3EA0B0, 0xA144, 0x4797, 0xB9, 0x5B, 0x53, 0xFA, \
178-
0x24, 0x2B, 0x6E, 0x1D)
177+
GUID_INIT(0xDC3EA0B0, 0xA144, 0x4797, 0xB9, 0x5B, 0x53, 0xFA, \
178+
0x24, 0x2B, 0x6E, 0x1D)
179179
/* Processor Specific: IA64 */
180180
#define CPER_SEC_PROC_IPF \
181-
UUID_LE(0xE429FAF1, 0x3CB7, 0x11D4, 0x0B, 0xCA, 0x07, 0x00, \
182-
0x80, 0xC7, 0x3C, 0x88, 0x81)
181+
GUID_INIT(0xE429FAF1, 0x3CB7, 0x11D4, 0x0B, 0xCA, 0x07, 0x00, \
182+
0x80, 0xC7, 0x3C, 0x88, 0x81)
183183
/* Processor Specific: ARM */
184184
#define CPER_SEC_PROC_ARM \
185-
UUID_LE(0xE19E3D16, 0xBC11, 0x11E4, 0x9C, 0xAA, 0xC2, 0x05, \
186-
0x1D, 0x5D, 0x46, 0xB0)
185+
GUID_INIT(0xE19E3D16, 0xBC11, 0x11E4, 0x9C, 0xAA, 0xC2, 0x05, \
186+
0x1D, 0x5D, 0x46, 0xB0)
187187
/* Platform Memory */
188188
#define CPER_SEC_PLATFORM_MEM \
189-
UUID_LE(0xA5BC1114, 0x6F64, 0x4EDE, 0xB8, 0x63, 0x3E, 0x83, \
190-
0xED, 0x7C, 0x83, 0xB1)
189+
GUID_INIT(0xA5BC1114, 0x6F64, 0x4EDE, 0xB8, 0x63, 0x3E, 0x83, \
190+
0xED, 0x7C, 0x83, 0xB1)
191191
#define CPER_SEC_PCIE \
192-
UUID_LE(0xD995E954, 0xBBC1, 0x430F, 0xAD, 0x91, 0xB4, 0x4D, \
193-
0xCB, 0x3C, 0x6F, 0x35)
192+
GUID_INIT(0xD995E954, 0xBBC1, 0x430F, 0xAD, 0x91, 0xB4, 0x4D, \
193+
0xCB, 0x3C, 0x6F, 0x35)
194194
/* Firmware Error Record Reference */
195195
#define CPER_SEC_FW_ERR_REC_REF \
196-
UUID_LE(0x81212A96, 0x09ED, 0x4996, 0x94, 0x71, 0x8D, 0x72, \
197-
0x9C, 0x8E, 0x69, 0xED)
196+
GUID_INIT(0x81212A96, 0x09ED, 0x4996, 0x94, 0x71, 0x8D, 0x72, \
197+
0x9C, 0x8E, 0x69, 0xED)
198198
/* PCI/PCI-X Bus */
199199
#define CPER_SEC_PCI_X_BUS \
200-
UUID_LE(0xC5753963, 0x3B84, 0x4095, 0xBF, 0x78, 0xED, 0xDA, \
201-
0xD3, 0xF9, 0xC9, 0xDD)
200+
GUID_INIT(0xC5753963, 0x3B84, 0x4095, 0xBF, 0x78, 0xED, 0xDA, \
201+
0xD3, 0xF9, 0xC9, 0xDD)
202202
/* PCI Component/Device */
203203
#define CPER_SEC_PCI_DEV \
204-
UUID_LE(0xEB5E4685, 0xCA66, 0x4769, 0xB6, 0xA2, 0x26, 0x06, \
205-
0x8B, 0x00, 0x13, 0x26)
204+
GUID_INIT(0xEB5E4685, 0xCA66, 0x4769, 0xB6, 0xA2, 0x26, 0x06, \
205+
0x8B, 0x00, 0x13, 0x26)
206206
#define CPER_SEC_DMAR_GENERIC \
207-
UUID_LE(0x5B51FEF7, 0xC79D, 0x4434, 0x8F, 0x1B, 0xAA, 0x62, \
208-
0xDE, 0x3E, 0x2C, 0x64)
207+
GUID_INIT(0x5B51FEF7, 0xC79D, 0x4434, 0x8F, 0x1B, 0xAA, 0x62, \
208+
0xDE, 0x3E, 0x2C, 0x64)
209209
/* Intel VT for Directed I/O specific DMAr */
210210
#define CPER_SEC_DMAR_VT \
211-
UUID_LE(0x71761D37, 0x32B2, 0x45cd, 0xA7, 0xD0, 0xB0, 0xFE, \
212-
0xDD, 0x93, 0xE8, 0xCF)
211+
GUID_INIT(0x71761D37, 0x32B2, 0x45cd, 0xA7, 0xD0, 0xB0, 0xFE, \
212+
0xDD, 0x93, 0xE8, 0xCF)
213213
/* IOMMU specific DMAr */
214214
#define CPER_SEC_DMAR_IOMMU \
215-
UUID_LE(0x036F84E1, 0x7F37, 0x428c, 0xA7, 0x9E, 0x57, 0x5F, \
216-
0xDF, 0xAA, 0x84, 0xEC)
215+
GUID_INIT(0x036F84E1, 0x7F37, 0x428c, 0xA7, 0x9E, 0x57, 0x5F, \
216+
0xDF, 0xAA, 0x84, 0xEC)
217217

218218
#define CPER_PROC_VALID_TYPE 0x0001
219219
#define CPER_PROC_VALID_ISA 0x0002
@@ -290,10 +290,10 @@ struct cper_record_header {
290290
__u32 validation_bits;
291291
__u32 record_length;
292292
__u64 timestamp;
293-
uuid_le platform_id;
294-
uuid_le partition_id;
295-
uuid_le creator_id;
296-
uuid_le notification_type;
293+
guid_t platform_id;
294+
guid_t partition_id;
295+
guid_t creator_id;
296+
guid_t notification_type;
297297
__u64 record_id;
298298
__u32 flags;
299299
__u64 persistence_information;
@@ -309,8 +309,8 @@ struct cper_section_descriptor {
309309
__u8 validation_bits;
310310
__u8 reserved; /* must be zero */
311311
__u32 flags;
312-
uuid_le section_type;
313-
uuid_le fru_id;
312+
guid_t section_type;
313+
guid_t fru_id;
314314
__u32 section_severity;
315315
__u8 fru_text[20];
316316
};
@@ -343,7 +343,7 @@ struct cper_sec_proc_ia {
343343

344344
/* IA32/X64 Processor Error Information Structure */
345345
struct cper_ia_err_info {
346-
uuid_le err_type;
346+
guid_t err_type;
347347
__u64 validation_bits;
348348
__u64 check_info;
349349
__u64 target_id;

include/linux/efi.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,10 @@ typedef u16 efi_char16_t; /* UNICODE character */
4747
typedef u64 efi_physical_addr_t;
4848
typedef void *efi_handle_t;
4949

50-
typedef uuid_le efi_guid_t;
50+
typedef guid_t efi_guid_t;
5151

5252
#define EFI_GUID(a,b,c,d0,d1,d2,d3,d4,d5,d6,d7) \
53-
UUID_LE(a, b, c, d0, d1, d2, d3, d4, d5, d6, d7)
53+
GUID_INIT(a, b, c, d0, d1, d2, d3, d4, d5, d6, d7)
5454

5555
/*
5656
* Generic EFI table header

0 commit comments

Comments
 (0)