ceph: fix NULL pointer dereference in ceph_flush_snaps()

ukernel · idryomov · commit c858a0709f99 · 2017-09-06T19:56:52.000+02:00
Signed-off-by: "Yan, Zheng" &lt;zyan@redhat.com&gt;
Signed-off-by: Ilya Dryomov &lt;idryomov@gmail.com&gt;
diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c
@@ -1469,7 +1469,7 @@ void ceph_flush_snaps(struct ceph_inode_info *ci,
 
 	if (psession) {
 		*psession = session;
-	} else {
+	} else if (session) {
 		mutex_unlock(&session->s_mutex);
 		ceph_put_mds_session(session);
 	}

Original file line number	Diff line number	Diff line change
`@@ -1469,7 +1469,7 @@ void ceph_flush_snaps(struct ceph_inode_info *ci,`
`1469`	`1469`
`1470`	`1470`	`if (psession) {`
`1471`	`1471`	`*psession = session;`
`1472`		`- } else {`
	`1472`	`+ } else if (session) {`
`1473`	`1473`	`mutex_unlock(&session->s_mutex);`
`1474`	`1474`	`ceph_put_mds_session(session);`
`1475`	`1475`	`}`