iio: 104-quad-8: Fix off-by-one error when addressing flag register

William Breathitt Gray · jic23 · commit ca8d8e03b4c9 · 2017-02-11T09:36:38.000Z
The flag register is offset by 1 from the respective channel data register. This patch fixes an off-by-one error when attempting to read a channel flag register where the base address was not properly offset. Fixes: 28e5d3b ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8") Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
diff --git a/drivers/iio/counter/104-quad-8.c b/drivers/iio/counter/104-quad-8.c
@@ -76,7 +76,7 @@ static int quad8_read_raw(struct iio_dev *indio_dev,
 			return IIO_VAL_INT;
 		}
 
-		flags = inb(base_offset);
+		flags = inb(base_offset + 1);
 		borrow = flags & BIT(0);
 		carry = !!(flags & BIT(1));
 

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ static int quad8_read_raw(struct iio_dev *indio_dev,`
`76`	`76`	`return IIO_VAL_INT;`
`77`	`77`	`}`
`78`	`78`
`79`		`- flags = inb(base_offset);`
	`79`	`+ flags = inb(base_offset + 1);`
`80`	`80`	`borrow = flags & BIT(0);`
`81`	`81`	`carry = !!(flags & BIT(1));`
`82`	`82`