Skip to content

Commit e8a27f8

Browse files
NeilBrownshligit
authored andcommitted
md/bitmap: disable bitmap_resize for file-backed bitmaps.
bitmap_resize() does not work for file-backed bitmaps. The buffer_heads are allocated and initialized when the bitmap is read from the file, but resize doesn't read from the file, it loads from the internal bitmap. When it comes time to write the new bitmap, the bh is non-existent and we crash. The common case when growing an array involves making the array larger, and that normally means making the bitmap larger. Doing that inside the kernel is possible, but would need more code. It is probably easier to require people who use file-backed bitmaps to remove them and re-add after a reshape. So this patch disables the resizing of arrays which have file-backed bitmaps. This is better than crashing. Reported-by: Zhilong Liu <[email protected]> Fixes: d60b479 ("md/bitmap: add bitmap_resize function to allow bitmap resizing.") Cc: [email protected] (v3.5+). Signed-off-by: NeilBrown <[email protected]> Signed-off-by: Shaohua Li <[email protected]>
1 parent 675dc2c commit e8a27f8

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

drivers/md/bitmap.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2058,6 +2058,11 @@ int bitmap_resize(struct bitmap *bitmap, sector_t blocks,
20582058
long pages;
20592059
struct bitmap_page *new_bp;
20602060

2061+
if (bitmap->storage.file && !init) {
2062+
pr_info("md: cannot resize file-based bitmap\n");
2063+
return -EINVAL;
2064+
}
2065+
20612066
if (chunksize == 0) {
20622067
/* If there is enough space, leave the chunk size unchanged,
20632068
* else increase by factor of two until there is enough space.

0 commit comments

Comments
 (0)