Allow marking every entry in a subscription as read (#596)

Author: chvp

app/controllers/subscriptions_controller.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class SubscriptionsController < ApplicationController
-  before_action :set_subscription, only: %i[show edit update destroy]
+  before_action :set_subscription, only: %i[show edit update mark_all_as_read destroy]
   def index
     authorize Subscription
     @subscriptions = policy_scope(Subscription)
@@ -42,6 +42,11 @@ def update
     end
   end
 
+  def mark_all_as_read
+    @subscription.entries.unread.each { |it| it.update(read_at: DateTime.current) }
+    redirect_to @subscription
+  end
+
   def destroy
     # This method should not fail
     @subscription.destroy!

app/models/subscription.rb

@@ -45,6 +45,10 @@ def refreshable?
     subscribable.respond_to? :refresh!
   end
 
+  def any_unread?
+    entries.unread.exists?
+  end
+
   def last_fetched_info
     return nil unless refreshable? && subscribable.last_fetched_at.present?
 

app/policies/subscription_policy.rb

@@ -23,6 +23,10 @@ def update?
     record.user_id == user&.id
   end
 
+  def mark_all_as_read?
+    record.user_id == user&.id
+  end
+
   def destroy?
     record.user_id == user&.id
   end

app/views/subscriptions/show.html.erb

@@ -6,6 +6,10 @@
   </p>
 <%- end %>
 
+<%- if @subscription.any_unread? %>
+  <%= button_to t('.mark_all_as_read'), mark_all_as_read_subscription_path(@subscription), method: :post %>
+<%- end %>
+
 <table class="table">
   <thead class="table__head">
     <tr class="table__row table__row--head">

config/locales/en.yml

@@ -22,6 +22,7 @@ en:
       mark_as_unread: Mark as unread
       delete: Delete
       delete_confirm: "Are you sure? This can not be undone. Note that rss feed entries might show up again when the feed refreshes."
+      mark_all_as_read: Mark all as read
       next: "Next entry"
       previous: "Previous entry"
       nav_pagination_label: "Pagination navigation"

config/routes.rb

@@ -91,7 +91,11 @@
   root 'entries#index'
 
   # Resource based routes
-  resources :subscriptions
+  resources :subscriptions do
+    member do
+      post :mark_all_as_read
+    end
+  end
   resources :entries, only: %i[index show update destroy]
 
   # Special routes for sign in/out and profile

test/controllers/subscriptions_controller_test.rb

@@ -97,6 +97,17 @@ class SubscriptionsControllerTest < ActionDispatch::IntegrationTest
     assert_response :unprocessable_entity
   end
 
+  # Mark all as read
+  test 'should mark all as read' do
+    entries = create_list :entry, 5, :with_all_details, subscription: @subscription
+
+    post mark_all_as_read_subscription_url(@subscription)
+
+    assert_redirected_to subscription_url(@subscription)
+
+    assert_equal((Array.new(5) { true }), (entries.map { |it| it.reload.read? }))
+  end
+
   # Destroy
   test 'should destroy subscription' do
     assert_difference 'Subscription.count', -1 do