Merge pull request #1474 from Toriniasty/feature/fix-Croydon

Simplify and fix wait for content, fixes Croydon council

Author: robbrad

uk_bin_collection/tests/input.json

@@ -614,8 +614,9 @@
         "postcode": "SE25 5DW",
         "skip_get_url": true,
         "url": "https://service.croydon.gov.uk/wasteservices/w/webpage/bin-day-enter-address",
+        "web_driver": "http://selenium:4444",
         "wiki_name": "Croydon",
-        "wiki_note": "Pass the house number and postcode in their respective parameters.",
+        "wiki_note": "Pass the house number and postcode in their respective parameters. This parser requires a Selenium webdriver.",
         "LAD24CD": "E09000008"
     },
     "CumberlandAllerdaleCouncil": {
@@ -745,7 +746,7 @@
         "wiki_note": "You will need to use [FindMyAddress](https://www.findmyaddress.co.uk/search) to find the UPRN.",
         "LAD24CD": "E07000061"
     },
-    "EastCambridgeshireCouncil": { 
+    "EastCambridgeshireCouncil": {
         "skip_get_url": true,
         "uprn": "10002597178",
         "url": "https://www.eastcambs.gov.uk/",
@@ -2803,4 +2804,4 @@
         "wiki_note": "Provide your UPRN.",
         "LAD24CD": "E06000014"
     }
-}
+}

uk_bin_collection/uk_bin_collection/councils/CroydonCouncil.py

@@ -79,12 +79,9 @@ def parse_data(self, page: str, **kwargs) -> dict:
             next_button.click()
 
             # Wait for the bin collection content to load
-            collection_content = WebDriverWait(driver, 10).until(
-                EC.presence_of_element_located(
-                    (
-                        By.XPATH,
-                        '//*[@id="mats_content_wrapper"]/div[2]/div[2]/div[2]/div/div[1]/div/div[3]/div/div/div/div',
-                    )
+            listing_records = WebDriverWait(driver, 10).until(
+                EC.presence_of_all_elements_located(
+                    (By.CSS_SELECTOR, "#mats_content_wrapper .listing_template_record")
                 )
             )