Skip to content

Commit 829f759

Browse files
committed
fix: removed duplicates in BradfordMDC
1 parent 771dcae commit 829f759

File tree

1 file changed

+19
-0
lines changed

1 file changed

+19
-0
lines changed

uk_bin_collection/uk_bin_collection/councils/BradfordMDC.py

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ def parse_data(self, page: str, **kwargs) -> dict:
106106
"%a %b %d %Y",
107107
).strftime(date_format),
108108
}
109+
print(dict_data)
109110
data["bins"].append(dict_data)
110111
for bin in soup.find_all(attrs={"id": re.compile(r"CTID-d3gapLk-\d+-A")}):
111112
dict_data = {
@@ -130,4 +131,22 @@ def parse_data(self, page: str, **kwargs) -> dict:
130131
key=lambda x: datetime.strptime(x.get("collectionDate"), date_format)
131132
)
132133

134+
data["bins"].sort(
135+
key=lambda x: datetime.strptime(x.get("collectionDate"), date_format)
136+
)
137+
138+
# Deduplicate the bins based on type and collection date
139+
# Feels a bit hacky, but fixes
140+
# https://github.com/robbrad/UKBinCollectionData/issues/1436
141+
unique_bins = []
142+
seen = set()
143+
for bin_item in data["bins"]:
144+
# Create a unique identifier for each bin entry
145+
bin_key = (bin_item["type"], bin_item["collectionDate"])
146+
if bin_key not in seen:
147+
seen.add(bin_key)
148+
unique_bins.append(bin_item)
149+
150+
data["bins"] = unique_bins
151+
133152
return data

0 commit comments

Comments
 (0)