Skip to content

Commit e55b056

Browse files
authored
Merge pull request #1466 from robbrad/fix_github_actions_parity_check_script_test
Fix GitHub actions parity check script test
2 parents 588fbf9 + 94ca95e commit e55b056

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

.github/workflows/behave_pull_request.yml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -103,12 +103,13 @@ jobs:
103103

104104
- name: Install Dependencies
105105
run: make install-dev
106-
106+
107107
- name: Check Parity of Councils / input.json / Feature file
108-
run: |
109-
repo=${{ github.event.pull_request.head.repo.full_name || 'robbrad/UKBinCollectionData' }}
110-
branch=${{ github.event.pull_request.head.ref || 'master' }}
111-
make parity-check repo=$repo branch=$branch
108+
env:
109+
repo: ${{ github.event.pull_request.head.repo.full_name || 'robbrad/UKBinCollectionData' }}
110+
branch: ${{ github.event.pull_request.head.ref || 'master' }}
111+
run: make parity-check repo="$repo" branch="$branch"
112+
112113
integration-tests:
113114
name: Run Integration Tests
114115
needs: setup
@@ -151,4 +152,4 @@ jobs:
151152
report_type: test_results
152153
file: build/${{ matrix.python-version }}/integration-test-results/junit.xml
153154
flags: integrationtestspr
154-
name: integration-tests-pr
155+
name: integration-tests-pr

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ generate-test-map-test-results:
5656
poetry run python uk_bin_collection/tests/generate_map_test_results.py build/integration-test-results/junit.xml > build/integration-test-results/test_results.json
5757

5858
parity-check:
59-
poetry run python uk_bin_collection/tests/council_feature_input_parity.py $(repo) $(branch)
59+
poetry run python uk_bin_collection/tests/council_feature_input_parity.py "$(repo)" "$(branch)"
6060

6161
unit-tests:
6262
poetry run coverage erase

uk_bin_collection/uk_bin_collection/councils/CheshireEastCouncil.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
This module provides bin collection data for Cheshire East Council.
1010
"""
1111

12-
1312
class CouncilClass(AbstractGetBinDataClass):
1413
"""
1514
A class to fetch and parse bin collection data for Cheshire East Council.

0 commit comments

Comments
 (0)