-
As I understood it, skip_get_url can be used to avoid asking for a council url in the Home Assistant integration. What happens if skip_get_url is used and the URL is not hard coded into the script? Does it take it from inputs.json? |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 2 replies
-
URL is still passed to the integration inside kwargs, just the generic get page handler I wrote is bypassed. Part of the issue though is in the custom component if skip get url is set then the user is not asked for this. A better way would be to have it so the user is not asked if URL is not supplied in input.json - but thats a big change. skip get url bypasses get_data in get_and_parse_data within get_bin_data.py I had planned to have a little code as possible in each council integration - but that was a bit utopian The project refactoring design started as https://refactoring.guru/design-patterns/template-method - This is how the abstract class works by setting a template that people can repeat and use - allowing for the council integrations to be "light touch" |
Beta Was this translation helpful? Give feedback.
-
omg - tiny back then b9918e9 |
Beta Was this translation helpful? Give feedback.
Yes