Skip to content

Commit facf9ba

Browse files
committed
add explicit test for non backed enums in custom properties
1 parent a92fde9 commit facf9ba

File tree

2 files changed

+10
-39
lines changed

2 files changed

+10
-39
lines changed

src/Actions/ResolveForPropertyValueAction.php

Lines changed: 0 additions & 39 deletions
This file was deleted.

tests/ActivityLoggerTest.php

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
<?php
22

33
use Carbon\Carbon;
4+
use Illuminate\Database\Eloquent\JsonEncodingException;
45
use Illuminate\Support\Collection;
56
use Spatie\Activitylog\Exceptions\CouldNotLogActivity;
67
use Spatie\Activitylog\Facades\CauserResolver;
78
use Spatie\Activitylog\LogOptions;
89
use Spatie\Activitylog\Models\Activity;
10+
use Spatie\Activitylog\Test\Enums\NonBackedEnum;
911
use Spatie\Activitylog\Test\Models\Article;
1012
use Spatie\Activitylog\Test\Models\User;
1113
use Spatie\Activitylog\Traits\LogsActivity;
@@ -440,3 +442,11 @@ public function tapActivity(Activity $activity, string $eventName)
440442
$this->assertSame(0, $this->getLastActivity()->properties['int_backed_enum']);
441443
$this->assertSame('published', $this->getLastActivity()->properties['string_backed_enum']);
442444
})->skip(version_compare(PHP_VERSION, '8.1', '<'), "PHP < 8.1 doesn't support enum");
445+
446+
it('does not log non backed enums in properties', function () {
447+
activity()
448+
->withProperty('non_backed_enum', NonBackedEnum::Published)
449+
->log($this->activityDescription);
450+
})
451+
->throws(JsonEncodingException::class)
452+
->skip(version_compare(PHP_VERSION, '8.1', '<'), "PHP < 8.1 doesn't support enum");

0 commit comments

Comments
 (0)