Skip to content
This repository was archived by the owner on Aug 28, 2020. It is now read-only.

Commit 10af7ae

Browse files
committed
Merge pull request #115 from robertbasic/fix/issue114
add full filename in a hidden column, to allow to jump to line in a file. Fixes #114
2 parents f487a61 + 6b877bc commit 10af7ae

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

pugdebug/gui/breakpoints.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,10 @@ def __init__(self):
2323
super(PugdebugBreakpointViewer, self).__init__()
2424

2525
self.setColumnCount(2)
26-
self.setHeaderLabels(['File', 'Line'])
26+
self.setHeaderLabels(['File', 'Line', 'Full filename'])
2727

2828
self.setColumnWidth(0, 350)
29+
self.setColumnHidden(2, True)
2930

3031
self.itemDoubleClicked.connect(self.handle_item_double_clicked)
3132

@@ -34,15 +35,19 @@ def set_breakpoints(self, breakpoints):
3435

3536
for breakpoint in breakpoints:
3637
filename = self.__cut_filename(breakpoint['filename'])
37-
args = [filename, str(breakpoint['lineno'])]
38+
args = [
39+
filename,
40+
str(breakpoint['lineno']),
41+
breakpoint['filename']
42+
]
3843

3944
item = QTreeWidgetItem(args)
4045
item.setToolTip(0, breakpoint['filename'])
4146

4247
self.addTopLevelItem(item)
4348

4449
def handle_item_double_clicked(self, item, column):
45-
file = item.text(0)
50+
file = item.text(2)
4651
line = int(item.text(1))
4752

4853
self.item_double_clicked_signal.emit(file, line)

pugdebug/gui/stacktraces.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,11 @@ def __init__(self):
2323
super(PugdebugStacktraceViewer, self).__init__()
2424

2525
self.setColumnCount(3)
26-
self.setHeaderLabels(['File', 'Line', 'Where'])
26+
self.setHeaderLabels(['File', 'Line', 'Where', 'Full filename'])
2727

2828
self.setColumnWidth(0, 350)
2929
self.setColumnWidth(1, 100)
30+
self.setColumnHidden(3, True)
3031

3132
self.itemDoubleClicked.connect(self.handle_item_double_clicked)
3233

@@ -38,15 +39,16 @@ def set_stacktraces(self, stacktraces):
3839
args = [
3940
filename,
4041
stacktrace['lineno'],
41-
stacktrace['where']
42+
stacktrace['where'],
43+
stacktrace['filename']
4244
]
4345
item = QTreeWidgetItem(args)
4446
item.setToolTip(0, stacktrace['filename'])
4547

4648
self.addTopLevelItem(item)
4749

4850
def handle_item_double_clicked(self, item, column):
49-
file = item.text(0)
51+
file = item.text(3)
5052
line = int(item.text(1))
5153

5254
self.item_double_clicked_signal.emit(file, line)

0 commit comments

Comments
 (0)